2.8 - lock before opening indexes if info - [MOD-10007] [MOD-9761] (#6279)#6340
Merged
BenGoldberger merged 1 commit into2.8from Jun 19, 2025
Merged
2.8 - lock before opening indexes if info - [MOD-10007] [MOD-9761] (#6279)#6340BenGoldberger merged 1 commit into2.8from
BenGoldberger merged 1 commit into2.8from
Conversation
* move the lock to include the opening of the indexes * add pytest * try to fix test * fix test * move lock sooner * spell checker * try to fix test * pr changes * pr changes * remove debugPrint in test * remove debug prints * add gc invokes while deleting docs * add timeout before read * add the timeout to gc struct * change timeout to 3 min * try to change the while * switch to poll * refactor gc struct * add gc_wait in test * pr changes * pr changes * pr changes * pr change * try to fix leak in test * revert priority change * remove deps changes * pr changes * revert len check (cherry picked from commit 52cbc9c)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6340 +/- ##
==========================================
- Coverage 87.05% 87.04% -0.01%
==========================================
Files 203 203
Lines 35827 35834 +7
==========================================
+ Hits 31189 31193 +4
- Misses 4638 4641 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the locking of the spec in IndexInfoCommand->fillReplyWithIndexInfo
Hopefully this will fix the bug and some flaky tests
Plus handle the while loop in FGC_recvFixed, that seems to block the gc thread