MOD-10176: Fix parser for negation of nonexistent function#6337
Merged
MOD-10176: Fix parser for negation of nonexistent function#6337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6337 +/- ##
==========================================
- Coverage 88.82% 88.77% -0.06%
==========================================
Files 245 245
Lines 40981 40983 +2
Branches 3483 3483
==========================================
- Hits 36402 36381 -21
- Misses 4536 4559 +23
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oshadmi
approved these changes
Jun 19, 2025
oshadmi
added
backport 2.8
backport 2.10
backport 8.0
and removed
backport 2.8
backport 2.10
labels
Collaborator
|
No need to backport to 2.8 and 2.10 since MOD-7804 #5520 was not backported to them and does not crash. |
raz-mon
reviewed
Jun 19, 2025
Collaborator
raz-mon
left a comment
raz-mon
left a comment
There was a problem hiding this comment.
LGTM
One question about the lexer.c update
raz-mon
approved these changes
Jun 19, 2025
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
Fix parser for negation of unexistent function (cherry picked from commit 8e3a0c6)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
MOD-10176: Fix parser for negation of nonexistent function (#6337) Fix parser for negation of unexistent function (cherry picked from commit 8e3a0c6) Co-authored-by: nafraf <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable