[MOD-10177] Rust benchmark for numeric encoder and decoder#6336
Merged
[MOD-10177] Rust benchmark for numeric encoder and decoder#6336
numeric encoder and decoder#6336Conversation
chesedo
force-pushed
the
migrate_encoders_decoders_bencher
branch
from
8e072eb to
0c1ac1e
Compare
This creates a Rust benchmark runner for the C numeric encoder and decoder only. This will serve as a base for more encoder / decoder benchmarks.
chesedo
force-pushed
the
migrate_encoders_decoders_bencher
branch
from
0c1ac1e to
642d30d
Compare
chesedo
changed the title
numeric encoder and decodernumeric encoder and decoder
The benchmarks are using the Rust wrapper instead.
This means `numeric_index.h` no longer needs a path to include `inverted_index.h`.
This is make the benchmark more accurate.
chesedo
commented
Jun 18, 2025
gdesmott
reviewed
Jun 18, 2025
This allows us to not worry about growth allocations and correctly clears the memory after the buffer was used.
We won't need this as the output of the C and Rust should be exactly the same. So there is no memory usage to compare.
Missed fix for new file coming from master.
LukeMathWalker
previously approved these changes
Jun 19, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6336 +/- ##
==========================================
- Coverage 88.84% 88.76% -0.09%
==========================================
Files 247 250 +3
Lines 41213 41503 +290
Branches 3483 3632 +149
==========================================
+ Hits 36617 36839 +222
- Misses 4553 4615 +62
- Partials 43 49 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdesmott
reviewed
Jun 23, 2025
We should not want to grow the buffer for the inverted index tests and benchmarks since that belongs in the buffer code. Instead we should always make a buffer that is big enough for whatever is encoded into it. This removes the `new` and add a `with_capacity` to make sure we always use the test buffer in this way.
BenGoldberger
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This creates a Rust benchmark runner for the C numeric encoder and decoder only. This will serve as a base for more encoder / decoder benchmarks.
Mark if applicable