[2.8] Add redisearch_thpool_wait in redisearch_thpool_destroy [MOD-10105]#6315
Merged
[2.8] Add redisearch_thpool_wait in redisearch_thpool_destroy [MOD-10105]#6315
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6315 +/- ##
==========================================
+ Coverage 85.85% 86.25% +0.40%
==========================================
Files 205 205
Lines 34667 34665 -2
==========================================
+ Hits 29765 29902 +137
+ Misses 4902 4763 -139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Jun 15, 2025
deps/thpool/thpool.c
Outdated
| // Wait for all jobs to finish | ||
| redisearch_thpool_wait(thpool_p); | ||
|
|
||
| // Wait for all jobs to finish |
Collaborator
There was a problem hiding this comment.
Am I drunk, or do I see double?
alonre24
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6303 to 2.8.