MOD-9403: Replace varint.* with the Rust implementation#6308
Merged
LukeMathWalker merged 6 commits intomasterfrom Jun 24, 2025
Merged
MOD-9403: Replace varint.* with the Rust implementation#6308LukeMathWalker merged 6 commits intomasterfrom
LukeMathWalker merged 6 commits intomasterfrom
Conversation
zeenix
force-pushed
the
drop-c-varint
branch
2 times, most recently
from
dbd66fa to
16b2811
Compare
2 tasks
LukeMathWalker
force-pushed
the
drop-c-varint
branch
from
fd9dbbb to
81f1623
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6308 +/- ##
==========================================
- Coverage 88.80% 88.75% -0.05%
==========================================
Files 243 251 +8
Lines 40893 41358 +465
Branches 3483 3636 +153
==========================================
+ Hits 36313 36709 +396
- Misses 4537 4600 +63
- Partials 43 49 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LukeMathWalker
force-pushed
the
drop-c-varint
branch
from
81f1623 to
2b1653a
Compare
| match token { | ||
| Token::Any => { | ||
| let num_chars = rng.borrow_mut().gen_range(1..=10); | ||
| let num_chars = rng.borrow_mut().random_range(1..=10); |
Collaborator
There was a problem hiding this comment.
I had to update the lockfile, and the latest version of proptest marked this as deprecated.
LukeMathWalker
force-pushed
the
drop-c-varint
branch
2 times, most recently
from
3dee9df to
a7148bf
Compare
LukeMathWalker
force-pushed
the
drop-c-varint
branch
2 times, most recently
from
15a2bc7 to
dffc306
Compare
This is the Rust re-implementation of the Varint* API. We'll use this later to replace the C version.
LukeMathWalker
force-pushed
the
drop-c-varint
branch
from
dffc306 to
d56e3fc
Compare
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
chesedo
reviewed
Jun 17, 2025
Collaborator
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
Left a few nit pick comments and some questions
chesedo
previously approved these changes
Jun 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the porting of the varint module from C to Rust.
This PR is based on PR #6287. It mainly just drops the C implementation in favour of the Rust one
that's added by #6287.
Mark if applicable