[MOD-8843] - refactor NotIterator - NonOptimized #6307
Merged
Conversation
…efactor-no-iterator
…efactor-no-iterator
…efactor-no-iterator
…efactor-no-iterator
Co-authored-by: GuyAv46 <[email protected]>
…efactor-no-iterator
…efactor-no-iterator
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6307 +/- ##
==========================================
- Coverage 88.90% 88.79% -0.12%
==========================================
Files 241 244 +3
Lines 40793 40971 +178
Branches 3435 3483 +48
==========================================
+ Hits 36266 36379 +113
- Misses 4491 4549 +58
- Partials 36 43 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…efactor-no-iterator-no-optimized
GuyAv46
reviewed
Jun 16, 2025
Co-authored-by: GuyAv46 <[email protected]>
GuyAv46
approved these changes
Jun 17, 2025
Collaborator
GuyAv46
left a comment
GuyAv46
left a comment
There was a problem hiding this comment.
Consider removing the sleeping mechanism from the mock, as we don't have a way to mock embedded timeout checks at the moment
Collaborator
Author
|
Since @BenGoldberger had approved previously the Optimized+NonOptimized implementation, I proceed with merging when ready |
auto-merge was automatically disabled
June 17, 2025 09:57
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Split from #6238
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable