Add redisearch_thpool_wait in redisearch_thpool_destroy [MOD-10105]#6303
Merged
Add redisearch_thpool_wait in redisearch_thpool_destroy [MOD-10105]#6303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6303 +/- ##
==========================================
- Coverage 88.88% 88.87% -0.02%
==========================================
Files 239 241 +2
Lines 40266 40793 +527
Branches 3165 3435 +270
==========================================
+ Hits 35791 36254 +463
- Misses 4440 4503 +63
- Partials 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Jun 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6303-to-2.8 origin/2.8
cd .worktree/backport-6303-to-2.8
git switch --create backport-6303-to-2.8
git cherry-pick -x 1f3a9c56de71cf8b58d3d4615fbb092382aa78bb |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-6303-to-2.6 origin/2.6
cd .worktree/backport-6303-to-2.6
git switch --create backport-6303-to-2.6
git cherry-pick -x 1f3a9c56de71cf8b58d3d4615fbb092382aa78bb |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…105] (#6310) Add redisearch_thpool_wait in redisearch_thpool_destroy [MOD-10105] (#6303) * Add wait * remove unnecessary check (cherry picked from commit 1f3a9c5) Co-authored-by: lerman25 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…0105] (#6309) Add redisearch_thpool_wait in redisearch_thpool_destroy [MOD-10105] (#6303) * Add wait * remove unnecessary check (cherry picked from commit 1f3a9c5) Co-authored-by: lerman25 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in redisearch_thpool_destroy we call redisearch_thpool_terminate_threadsimmediatly,
this can result in a race condition in bg indexing in which the thpool is destroyed before the bg indexing task started and thus creating a leak.
Validate gh-readonly-queue/2.10/pr-6294-e7ddc75819184ebfd0cc11cff3d1a6328f231996 · RediSearch/RediSearch@0123c19