Merged
Conversation
chesedo
reviewed
Jun 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6300 +/- ##
==========================================
- Coverage 88.88% 88.81% -0.07%
==========================================
Files 240 240
Lines 40524 40524
Branches 3165 3165
==========================================
- Hits 36018 35991 -27
- Misses 4471 4498 +27
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JonasKruckenberg
force-pushed
the
push-wnqtzkqvnwus
branch
from
6bd92cd to
cc60300
Compare
JonasKruckenberg
force-pushed
the
push-wnqtzkqvnwus
branch
from
cc60300 to
10828bf
Compare
chesedo
reviewed
Jun 11, 2025
chesedo
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a simple one-line fix for the Rust
fficrate build issues. We don't need theFP_constants and since they cause trouble, lets just disable generation of them.