Skip to content

MOD-9856: Check For Timeout Inside RpidxNext Loop#6298

Merged
kei-nan merged 2 commits intomasterfrom
master_jk_check_timeout_in_rpidx_next_loop
Jun 11, 2025
Merged

MOD-9856: Check For Timeout Inside RpidxNext Loop#6298
kei-nan merged 2 commits intomasterfrom
master_jk_check_timeout_in_rpidx_next_loop

Conversation

@kei-nan
Copy link
Collaborator

@kei-nan kei-nan commented Jun 10, 2025

Describe the changes in the pull request

Check for timeout inside the rpidxNext loop to avoid getting killed by watchdog.

A clear and concise description of what the PR is solving, including:

  1. Current: Once we go into the loop of reading from the iterator tree we don't check for timeouts in the result processor, we seem to rely on the iterators to perform the timeout check.
  2. Change: Check for timeout in the rpidx result processor read function.
  3. Outcome: Avoid getting killed by the watchdog.

Main objects this PR modified

  1. Rpidx result processor.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@kei-nan kei-nan requested review from GuyAv46 and raz-mon June 10, 2025 14:53
@kei-nan kei-nan self-assigned this Jun 10, 2025
@codecov
Copy link

codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (acd8639) to head (34c74ef).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6298      +/-   ##
==========================================
- Coverage   88.88%   88.87%   -0.01%     
==========================================
  Files         240      240              
  Lines       40515    40515              
  Branches     3165     3165              
==========================================
- Hits        36011    36008       -3     
- Misses       4469     4472       +3     
  Partials       35       35
Flag Coverage Δ
flow 82.22% <100.00%> (-0.13%) ⬇️
unit 46.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kei-nan kei-nan added this pull request to the merge queue Jun 11, 2025
Merged via the queue into master with commit 912f4d2 Jun 11, 2025
18 checks passed
@kei-nan kei-nan deleted the master_jk_check_timeout_in_rpidx_next_loop branch June 11, 2025 08:07
@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jun 11, 2025

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-6298-to-2.8 origin/2.8
cd .worktree/backport-6298-to-2.8
git switch --create backport-6298-to-2.8
git cherry-pick -x 912f4d20260e7b16a04b5d242c3eb1abf39dea63

@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jun 11, 2025

Backport failed for 2.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.6
git worktree add -d .worktree/backport-6298-to-2.6 origin/2.6
cd .worktree/backport-6298-to-2.6
git switch --create backport-6298-to-2.6
git cherry-pick -x 912f4d20260e7b16a04b5d242c3eb1abf39dea63

@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jun 11, 2025

Backport failed for 2.10, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.10
git worktree add -d .worktree/backport-6298-to-2.10 origin/2.10
cd .worktree/backport-6298-to-2.10
git switch --create backport-6298-to-2.10
git cherry-pick -x 912f4d20260e7b16a04b5d242c3eb1abf39dea63

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Jun 11, 2025
@kei-nan @github-actions
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)
c20cd2b 
* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Jun 11, 2025
Merged
@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jun 11, 2025

Successfully created backport PR for 8.0:

github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2025
@redisearch-backport-pull-request @kei-nan
[8.0] MOD-9856: Check For Timeout Inside RpidxNext Loop (#6299)
9f1bf12 
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)

* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)

Co-authored-by: kei-nan <[email protected]>
kei-nan added a commit that referenced this pull request Jun 12, 2025
@kei-nan
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)
cf0fbac 
* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)
@kei-nan kei-nan mentioned this pull request Jun 12, 2025
Merged
kei-nan added a commit that referenced this pull request Jun 12, 2025
@kei-nan
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)
56300ac 
* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)
@kei-nan kei-nan mentioned this pull request Jun 12, 2025
Merged
kei-nan added a commit that referenced this pull request Jun 12, 2025
@kei-nan
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)
a52f377 
* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)
@kei-nan kei-nan mentioned this pull request Jun 12, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2025
@kei-nan
[2.10] MOD-9856: Check For Timeout Inside RpidxNext Loop (#6304)
f274bfd 
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)

* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)
github-merge-queue bot pushed a commit that referenced this pull request Jun 15, 2025
@redisearch-backport-pull-request @kei-nan
[8.0] MOD-9856: Check For Timeout Inside RpidxNext Loop (#6299)
bf43119 
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)

* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)

Co-authored-by: kei-nan <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jun 15, 2025
@kei-nan
[2.8] MOD-9856: Check For Timeout Inside RpidxNext Loop (#6305)
7bd3489 
MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)

* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)
github-merge-queue bot pushed a commit that referenced this pull request Jun 15, 2025
@kei-nan
[2.6] MOD-9856: Check For Timeout Inside RpidxNext Loop (#6306)
eb23597 
* MOD-9856: Check For Timeout Inside RpidxNext Loop (#6298)

* check for timeout inside rpidxNext loop

* typo

(cherry picked from commit 912f4d2)

* fix compilation

* small fix

* compilation fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

@raz-mon raz-mon raz-mon approved these changes

Assignees

@kei-nan kei-nan

Labels

backport 2.6 backport 2.8 backport 2.10 size:XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kei-nan @GuyAv46 @raz-mon