[2.8] MOD-9835: Fix unicode_tolower()#6263
Merged
redisearch-backport-pull-request[bot] merged 5 commits into2.8from Jun 19, 2025
Merged
[2.8] MOD-9835: Fix unicode_tolower()#6263redisearch-backport-pull-request[bot] merged 5 commits into2.8from
redisearch-backport-pull-request[bot] merged 5 commits into2.8from
Conversation
* Bigger buffer and tests * Fixes * Fix tag_strtolower to fix test with escaped TAG * Fix typo * Fix rm_normalize() and test dialects * Update src/util/strconv.h Co-authored-by: meiravgri <[email protected]> * Enhance unicode_tolower comments for clarity on transformation behavior and buffer allocation * Fix assertion * Fix typo Co-authored-by: Copilot <[email protected]> * Refactor tag_strtolower to improve length handling and update test names for clarity on UTF-8 behavior * Add more tests * Add test comments * Simplify tests * Fix typo * Test with a single multi-byte char * Add cpp test for unicode_tolower() * Fix testSpecialUnicodeCase * update u_buffer allocation for better maintainability * Add tests lower UTF8 byes exceeding max size * Fix typo --------- Co-authored-by: nafraf <[email protected]> Co-authored-by: nafraf <[email protected]> Co-authored-by: meiravgri <[email protected]> Co-authored-by: Copilot <[email protected]> (cherry picked from commit eb11bfd)
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6263 +/- ##
==========================================
- Coverage 87.04% 87.04% -0.01%
==========================================
Files 203 203
Lines 35834 35837 +3
==========================================
+ Hits 31192 31193 +1
- Misses 4642 4644 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oshadmi
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6211 to
2.8.Changes:
test_utf8_lowercase_longer_than_uppercase_tagsbecause tag auto escaping is not supported in 2.8