[2.10] Backport OOM indexing to all branches [MOD-9715] #6262
Merged
[2.10] Backport OOM indexing to all branches [MOD-9715] #6262
Conversation
* Create dbg ctx and dbgIndScan * Fix * fixing mechanism and pytest * Add pause before scan mechanism and pytest * Revert "Add pause before scan mechanism and pytest" This reverts commit b842ce9. * Re-adding 'Add pause before scan mechanism and pytest' * fix testDebugHelp * fixing Guy's comment + skipping on cluster in pytest * Move volatile pause to BG scanner, move debug scanner flag to base IndexesScanner * fix pytest * thread safety * Cover more code * pause before scan coverage * fix - can't create a flow to reach 'Debug mode enabled but scanner is not a debug scanner' error * fixing Alon's comment * wrong arity check and comment on not used function * format
lerman25
added
enforce:coverage
* fix flaky * comment * change to ceil
* change default value * change default value in config pytest * change index oom tests to lower value then new default * change debug commands tests to lower value then default value * change default value of set tight memory functions * 100testv1 * test default value
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #6262 +/- ##
==========================================
+ Coverage 86.50% 86.57% +0.06%
==========================================
Files 204 204
Lines 34691 34981 +290
==========================================
+ Hits 30011 30285 +274
- Misses 4680 4696 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lerman25
changed the title
alonre24
approved these changes
Jun 10, 2025
| // Indexing Errors | ||
| size_t indexing_failures; // Total count of indexing errors | ||
| size_t max_indexing_failures; // Maximum number of indexing errors among all specs | ||
| size_t background_indexing_failures_OOM; // Total count of background indexing errors due to OOM |
Collaborator
There was a problem hiding this comment.
Let's close this circle and add this metric to the Grafana dashboard - @meiravgri can help you with that
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports all OOM indexing PRs to 2.10.
#5672, #5778, #5941, #6053, #6114, #6140, #6203, #6276