Optional Iterator refactor - [MOD-8844]#6260
Merged
BenGoldberger merged 83 commits intomasterfrom Jun 18, 2025
Merged
Conversation
It contains the code for the Optional Iterator refactor. Implementation has been taken from https://github.com/RediSearch/RediSearch/pull/5619/files
JoanFM
requested changes
Jun 5, 2025
tests/cpptests/micro-benchmarks/benchmark_optional_iterator.cpp
Outdated
Show resolved
Hide resolved
It contains the code for the Optional Iterator refactor. Implementation has been taken from https://github.com/RediSearch/RediSearch/pull/5619/files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6260 +/- ##
==========================================
- Coverage 88.79% 88.77% -0.02%
==========================================
Files 244 246 +2
Lines 40978 41051 +73
Branches 3483 3483
==========================================
+ Hits 36385 36444 +59
- Misses 4550 4564 +14
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
reviewed
Jun 8, 2025
tests/cpptests/micro-benchmarks/benchmark_optional_iterator.cpp
Outdated
Show resolved
Hide resolved
tests/cpptests/micro-benchmarks/benchmark_optional_iterator.cpp
Outdated
Show resolved
Hide resolved
tests/cpptests/micro-benchmarks/benchmark_optional_iterator.cpp
Outdated
Show resolved
Hide resolved
tests/cpptests/micro-benchmarks/benchmark_optional_iterator.cpp
Outdated
Show resolved
Hide resolved
It contains the code for the Optional Iterator refactor. Implementation has been taken from https://github.com/RediSearch/RediSearch/pull/5619/files
JoanFM
reviewed
Jun 11, 2025
GuyAv46
reviewed
Jun 17, 2025
GuyAv46
previously approved these changes
Jun 17, 2025
JoanFM
requested changes
Jun 17, 2025
JoanFM
previously approved these changes
Jun 17, 2025
GuyAv46
approved these changes
Jun 18, 2025
GuyAv46
reviewed
Jun 18, 2025
|
|
||
| // Create a new OPTIONAL iterator - Non-Optimized version. | ||
| QueryIterator *IT_V2(NewOptionalIterator)(QueryIterator *it, t_docId maxDocId, size_t numDocs, double weight) { | ||
| assert(it != NULL); |
Collaborator
There was a problem hiding this comment.
On a second look, this may happen (for example, when searching for ~foo but no document has foo so there is no inverted index for it)
I suggest we return a wildcard iterator in this case.
We have to check the implications on FT.PROFILE and FT.EXPLAIN when we start using the new iterators
Collaborator
There was a problem hiding this comment.
alternativly, use RS_ASSERT and we will have to handle this case when using the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It contains the code for the Optional Iterator refactor.
Implementation has been taken from https://github.com/RediSearch/RediSearch/pull/5619/files