Skip to content

[8.0] MOD-9609: Pass Private Data Context Back To UnblockClient API#6242

Merged
kei-nan merged 2 commits into8.0from
backport-6237-to-8.0
Jun 3, 2025
Merged

[8.0] MOD-9609: Pass Private Data Context Back To UnblockClient API#6242
kei-nan merged 2 commits into8.0from
backport-6237-to-8.0

Conversation

@kei-nan
Copy link
Collaborator

@kei-nan kei-nan commented Jun 3, 2025

Manual backport of #6237

* Apparently private data had to be sent back when unblocking the client in order for the free function to get called

* code review comment

* solve memory leak

(cherry picked from commit 608e4cb)
@kei-nan kei-nan requested a review from GuyAv46 June 3, 2025 07:33
@kei-nan kei-nan changed the base branch from master to 8.0 June 3, 2025 07:33
@kei-nan kei-nan enabled auto-merge June 3, 2025 07:33
@kei-nan kei-nan marked this pull request as draft June 3, 2025 07:42
auto-merge was automatically disabled June 3, 2025 07:42

Pull request was converted to draft

@kei-nan kei-nan marked this pull request as ready for review June 3, 2025 07:42
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (0612781) to head (b83ffc4).
Report is 1 commits behind head on 8.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #6242      +/-   ##
==========================================
+ Coverage   87.26%   88.02%   +0.75%     
==========================================
  Files         198      198              
  Lines       36185    36189       +4     
==========================================
+ Hits        31577    31854     +277     
+ Misses       4608     4335     -273     
Flag Coverage Δ
flow 83.45% <100.00%> (+0.63%) ⬆️
unit 40.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kei-nan kei-nan enabled auto-merge June 3, 2025 08:34
@kei-nan kei-nan added this pull request to the merge queue Jun 3, 2025
@GuyAv46
Copy link
Collaborator

GuyAv46 commented Jun 3, 2025

This fix should be added to the 2.10 backport of the original PR, even if we end up closing it

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2025
@kei-nan kei-nan added this pull request to the merge queue Jun 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2025
@kei-nan kei-nan added this pull request to the merge queue Jun 3, 2025
Merged via the queue into 8.0 with commit 93b86ae Jun 3, 2025
9 checks passed
@kei-nan kei-nan deleted the backport-6237-to-8.0 branch June 3, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants