[8.0] MOD-9609: Pass Private Data Context Back To UnblockClient API#6242
Merged
[8.0] MOD-9609: Pass Private Data Context Back To UnblockClient API#6242
Conversation
* Apparently private data had to be sent back when unblocking the client in order for the free function to get called * code review comment * solve memory leak (cherry picked from commit 608e4cb)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #6242 +/- ##
==========================================
+ Coverage 87.26% 88.02% +0.75%
==========================================
Files 198 198
Lines 36185 36189 +4
==========================================
+ Hits 31577 31854 +277
+ Misses 4608 4335 -273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Jun 3, 2025
Collaborator
|
This fix should be added to the 2.10 backport of the original PR, even if we end up closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #6237