refactor WildcardIterator (Not Optimized) - [MOD-8845]#6241
Merged
Conversation
JoanFM
changed the title
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6241 +/- ##
==========================================
- Coverage 88.84% 88.81% -0.04%
==========================================
Files 233 239 +6
Lines 39918 40255 +337
Branches 2881 3165 +284
==========================================
+ Hits 35464 35751 +287
- Misses 4420 4469 +49
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGoldberger
previously approved these changes
Jun 3, 2025
GuyAv46
reviewed
Jun 3, 2025
GuyAv46
reviewed
Jun 4, 2025
tests/cpptests/micro-benchmarks/benchmark_wildcard_non_optimized_iterator.cpp
Outdated
Show resolved
Hide resolved
…ed_iterator.cpp Co-authored-by: GuyAv46 <[email protected]>
GuyAv46
previously approved these changes
Jun 5, 2025
GuyAv46
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This is a split from #6238 to chunk the PR into smaller pieces.
It adds the refactoring of WildCardIterator Not Optimized
Mark if applicable