Merged
Conversation
cf924bd to
a3ba5ce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6238 +/- ##
==========================================
- Coverage 88.87% 88.86% -0.01%
==========================================
Files 247 247
Lines 41213 41273 +60
Branches 3483 3483
==========================================
+ Hits 36629 36679 +50
- Misses 4541 4551 +10
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 3, 2025
Merged
Collaborator
Author
…efactor-no-iterator
…efactor-no-iterator
…efactor-no-iterator
…efactor-no-iterator
…efactor-no-iterator
GuyAv46
requested changes
Jun 19, 2025
GuyAv46
reviewed
Jun 19, 2025
GuyAv46
reviewed
Jun 19, 2025
GuyAv46
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This will be the continuation of #6307
The PR does:
Mark if applicable
Note
I strongly believe that the OldIterator has a bug.
The Old implementation assumes that there are no DocID in the
childIteratorthat does not exist in thewildcard iterator(the child iterator (the negation functions) seems to be assumed to be a subgroup of the WildCard iterator).This test fails for OldIterator:
This seems to be OK for most of the times because the QueryEvalNode filters the Not Iterator conditions before creating the ChildIterator, but there may be some edge cases where this is not true.
This makes the Benchmarks look bad for this NEW implementation.
However, I added a set of tests where the conditions are met (_Subset) in the micro benchmarks, that show that the performance is comparable or slightly better for the new implementation