Skip to content

Add micro-benchmarks to CI - [MOD - 8849]#6230

Merged
JoanFM merged 40 commits intomasterfrom
joan-benchmarks-ci
Jun 12, 2025
Merged

Add micro-benchmarks to CI - [MOD - 8849]#6230
JoanFM merged 40 commits intomasterfrom
joan-benchmarks-ci

Conversation

@JoanFM
Copy link
Collaborator

@JoanFM JoanFM commented May 28, 2025 •
edited
Loading

Describe the changes in the pull request

Adds "micro-benchmark" runs to CI:

  • Create one benchmark binary for each of the micro benchmark test.
  • Add option to run the micro benchmarks in Makefile and build.sh
  • Add flow-micro-benchmark.yml and flow-micro-benchmark-runner.yml to run the actions in CI and collect its results.
  • Separate the logic between "Rust Micro Benchmarks" and "Micro Benchmarks"

The "diff" is weird because I renamed "flow-microbenchmark" to "flow-rust-micro-benchmark" but then I created it again to add the regular microbenchmarks.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@JoanFM JoanFM force-pushed the joan-benchmarks-ci branch from 1720688 to 2601436 Compare May 28, 2025 15:36
@JoanFM JoanFM requested a review from GuyAv46 May 28, 2025 15:54
@JoanFM JoanFM force-pushed the joan-benchmarks-ci branch from e24589b to 636b9d3 Compare May 28, 2025 15:58
@JoanFM JoanFM requested a review from fcostaoliveira May 29, 2025 07:08
@JoanFM JoanFM closed this May 29, 2025
@JoanFM JoanFM reopened this May 29, 2025
@JoanFM JoanFM force-pushed the joan-benchmarks-ci branch 7 times, most recently from cfbaede to c567cee Compare May 30, 2025 07:04
@JoanFM JoanFM force-pushed the joan-benchmarks-ci branch from c567cee to fa8f812 Compare May 30, 2025 07:16
@JoanFM JoanFM force-pushed the joan-benchmarks-ci branch from 6dac513 to 9c0a107 Compare June 4, 2025 06:56
GuyAv46
GuyAv46 reviewed Jun 12, 2025
View reviewed changes
@GuyAv46
Copy link
Collaborator

GuyAv46 commented Jun 12, 2025

We should also set the Grafana panels, right? The link in the comparison report links to the "end-to-end" benchmarks

JoanFM
JoanFM commented Jun 12, 2025
View reviewed changes
Copy link
Collaborator Author

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will apply the changes, just some answers to questions

Makefile Outdated

UPDATED_BINDIR:=$(subst arm64v8,aarch64,$(BINDIR))

micro-benchmarks:
Copy link
Collaborator Author

@JoanFM JoanFM Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I thought it was the other way around. I can remove yes

@JoanFM
Copy link
Collaborator Author

JoanFM commented Jun 12, 2025

We should also set the Grafana panels, right? The link in the comparison report links to the "end-to-end" benchmarks

Makes sense, not sure if it is part of the redis-compare call. @fcostaoliveira any idea?

dor-forer
dor-forer reviewed Jun 12, 2025
View reviewed changes
@JoanFM JoanFM requested review from GuyAv46 and dor-forer June 12, 2025 12:26
@JoanFM JoanFM force-pushed the joan-benchmarks-ci branch from 716684c to b95d21f Compare June 12, 2025 13:14
@JoanFM
Copy link
Collaborator Author

JoanFM commented Jun 12, 2025

We should also set the Grafana panels, right? The link in the comparison report links to the "end-to-end" benchmarks

Makes sense, not sure if it is part of the redis-compare call. @fcostaoliveira any idea?

@GuyAv46 parameter has been added to the compare

@RediSearch RediSearch deleted a comment from fcostaoliveira Jun 12, 2025
@JoanFM JoanFM closed this Jun 12, 2025
@JoanFM JoanFM reopened this Jun 12, 2025
@JoanFM JoanFM enabled auto-merge June 12, 2025 14:11
@JoanFM JoanFM disabled auto-merge June 12, 2025 14:12
@JoanFM JoanFM enabled auto-merge June 12, 2025 14:12
@JoanFM JoanFM added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@JoanFM JoanFM added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@JoanFM JoanFM added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@JoanFM JoanFM added this pull request to the merge queue Jun 12, 2025
Merged via the queue into master with commit 119d11a Jun 12, 2025
42 checks passed
@JoanFM JoanFM deleted the joan-benchmarks-ci branch June 12, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuyAv46 GuyAv46 GuyAv46 approved these changes

@dor-forer dor-forer dor-forer approved these changes

@fcostaoliveira fcostaoliveira Awaiting requested review from fcostaoliveira

Assignees

No one assigned

Labels

action:run-micro-benchmark size:M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoanFM @GuyAv46 @dor-forer