Skip to content

[8.0] Backport OOM indexing to all branches [MOD-9715]#6223

Merged
lerman25 merged 4 commits into8.0from
backport-6114-6140-6203-to-8.0
Jun 8, 2025
Merged

[8.0] Backport OOM indexing to all branches [MOD-9715]#6223
lerman25 merged 4 commits into8.0from
backport-6114-6140-6203-to-8.0

Conversation

@lerman25
Copy link
Collaborator

@lerman25 lerman25 commented May 27, 2025

This PR backports #6114 , #6140 , #6203 to 8.0
No notable conflicts

lerman25 added 3 commits May 27, 2025 17:40
* Add config

* insert oom_scan field to scanner, remove check for oom in debug pause on oom

* fix comment

* create basis for function

* handle last scanned key

* change sleep function name

* Add pause before and after reset

* Add pause before and after statuses code

* Add pause before and after reset to bg scan

* wait if config >0

* adjust default sleep time

* fix last scanned key

* temp tests

* bsaic test strcuture

* styling

* Add scanner status strings

* Add first test

* Add update option for dbug scanner and more tests

* remove scanner cancleation

* Alter and Drop tests

* spellcheck

* skip cluster in tests

* Add config test for new config

* shortern tests

* styling

* remove pause on OOM from drop test

* Add tests, style

* style

* style

* Remove unused pause after OOM reset

* debug commands tests and cluster tests

* Naming, styling, formatting

* rename, change structure for simplicity

* improve test robustness

* remove unused and move to better location

* Ben comments round1

* Add 0 thresh test

* comment

* ADd skip cluster

* change config and other Alon's comments

* small tess

* remove pause after
Remove duplicates in tests

* more test compression

* fix assert
* Add config

* insert oom_scan field to scanner, remove check for oom in debug pause on oom

* fix comment

* create basis for function

* handle last scanned key

* change sleep function name

* Add pause before and after reset

* Add pause before and after statuses code

* Add pause before and after reset to bg scan

* wait if config >0

* adjust default sleep time

* fix last scanned key

* temp tests

* bsaic test strcuture

* styling

* Add scanner status strings

* Add first test

* Add update option for dbug scanner and more tests

* remove scanner cancleation

* Alter and Drop tests

* spellcheck

* skip cluster in tests

* Add config test for new config

* shortern tests

* styling

* remove pause on OOM from drop test

* Add tests, style

* style

* style

* Remove unused pause after OOM reset

* debug commands tests and cluster tests

* Naming, styling, formatting

* rename, change structure for simplicity

* improve test robustness

* remove unused and move to better location

* remove OOM from ACL

* remove oom from aggregate_exec

* Change config help message

* remove from ft.search

* remove query error test

* Add warning to query_error

* Add warning to resp3

* Add resp3 test

* format

* revert pytest

* resp3 tests

* Ben comments round1

* Add 0 thresh test

* comment

* ADd skip cluster

* change config and other Alon's comments

* small tess

* remove pause after
Remove duplicates in tests

* more test compression

* fix assert

* FT.PROFILE and OOM string

* Add resp2 warning

* Revert "Add resp2 warning"

This reverts commit 6b73b3c.

* Add resp2 warning

* format
@lerman25 lerman25 changed the base branch from master to 8.0 May 27, 2025 14:53
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 97.16312% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.26%. Comparing base (32d54be) to head (f025f7f).
Report is 8 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/debug_commands.c 92.50% 3 Missing ⚠️
src/spec.c 98.41% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              8.0    #6223   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files         198      198           
  Lines       36174    36249   +75     
=======================================
+ Hits        31566    31634   +68     
- Misses       4608     4615    +7     
Flag Coverage Δ
flow 82.71% <97.16%> (-0.10%) ⬇️
unit 40.29% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lerman25 lerman25 added this pull request to the merge queue Jun 8, 2025
Merged via the queue into 8.0 with commit cc160ae Jun 8, 2025
9 checks passed
@lerman25 lerman25 deleted the backport-6114-6140-6203-to-8.0 branch June 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants