Skip to content

[2.6] [MOD-9396] Fix indexError leak#6216

Merged
meiravgri merged 4 commits into2.6from
backport-6193-to-2.6
May 29, 2025
Merged

[2.6] [MOD-9396] Fix indexError leak#6216
meiravgri merged 4 commits into2.6from
backport-6193-to-2.6

Conversation

@meiravgri
Copy link
Collaborator

backport #6193 to 2.6

meiravgri and others added 2 commits May 27, 2025 04:32
* free and invalidate NA_rstr (expect saniztizer to fail

* fix 1
should still leak on coordinator

* fix final leak - override AggregatedFieldSpecInfo and lose ref

* Change the number of issues

* change to 1024

* move fields IndexError_Clear to main thread

* remove rm_free(spec->fields);

* fix

* add header

---------

Co-authored-by: Dor Forer <[email protected]>
(cherry picked from commit d8b0313)
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.66%. Comparing base (8dcc897) to head (bd74135).
Report is 1 commits behind head on 2.6.

Files with missing lines Patch % Lines
src/info/index_error.c 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #6216      +/-   ##
==========================================
- Coverage   85.70%   85.66%   -0.04%     
==========================================
  Files         189      189              
  Lines       31653    31665      +12     
==========================================
- Hits        27129    27127       -2     
- Misses       4524     4538      +14     
Flag Coverage Δ
flow 79.42% <94.11%> (-0.30%) ⬇️
unit 44.49% <94.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri enabled auto-merge May 27, 2025 10:27
@meiravgri meiravgri requested a review from dor-forer May 27, 2025 10:27
dor-forer
dor-forer previously approved these changes May 27, 2025
@meiravgri meiravgri added this pull request to the merge queue May 29, 2025
@meiravgri meiravgri removed this pull request from the merge queue due to a manual request May 29, 2025
@meiravgri meiravgri added this pull request to the merge queue May 29, 2025
Merged via the queue into 2.6 with commit af865b8 May 29, 2025
10 checks passed
@meiravgri meiravgri deleted the backport-6193-to-2.6 branch May 29, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants