Skip to content

[2.8] [MOD-9396] Fix indexError leak #6208

Merged
meiravgri merged 3 commits into2.8from
backport-6193-to-2.8
May 29, 2025
Merged

[2.8] [MOD-9396] Fix indexError leak #6208
meiravgri merged 3 commits into2.8from
backport-6193-to-2.8

Conversation

@meiravgri
Copy link
Collaborator

backport #6193 to 2.8

* free and invalidate NA_rstr (expect saniztizer to fail

* fix 1
should still leak on coordinator

* fix final leak - override AggregatedFieldSpecInfo and lose ref

* Change the number of issues

* change to 1024

* move fields IndexError_Clear to main thread

* remove rm_free(spec->fields);

* fix

* add header

---------

Co-authored-by: Dor Forer <[email protected]>
(cherry picked from commit d8b0313)
@meiravgri meiravgri requested a review from dor-forer May 26, 2025 04:32
dor-forer
dor-forer previously approved these changes May 26, 2025
dor-forer
dor-forer previously approved these changes May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.85%. Comparing base (f0998d3) to head (890d7da).
Report is 2 commits behind head on 2.8.

Files with missing lines Patch % Lines
src/info/index_error.c 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.8    #6208   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         205      205           
  Lines       34657    34667   +10     
=======================================
+ Hits        29754    29763    +9     
- Misses       4903     4904    +1     
Flag Coverage Δ
flow 81.01% <93.75%> (-0.21%) ⬇️
unit 40.40% <93.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue May 29, 2025
Merged via the queue into 2.8 with commit 37aa03c May 29, 2025
9 checks passed
@meiravgri meiravgri deleted the backport-6193-to-2.8 branch May 29, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants