[2.10] [MOD-9396] Fix indexError leak #6207
Merged
Conversation
* free and invalidate NA_rstr (expect saniztizer to fail * fix 1 should still leak on coordinator * fix final leak - override AggregatedFieldSpecInfo and lose ref * Change the number of issues * change to 1024 * move fields IndexError_Clear to main thread * remove rm_free(spec->fields); * fix * add header --------- Co-authored-by: Dor Forer <[email protected]> (cherry picked from commit d8b0313)
dor-forer
previously approved these changes
May 26, 2025
dor-forer
approved these changes
May 26, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #6207 +/- ##
==========================================
- Coverage 86.51% 86.48% -0.03%
==========================================
Files 204 204
Lines 34682 34691 +9
==========================================
- Hits 30004 30002 -2
- Misses 4678 4689 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 26, 2025
* [MOD-9396] Fix indexError leak (#6193) * free and invalidate NA_rstr (expect saniztizer to fail * fix 1 should still leak on coordinator * fix final leak - override AggregatedFieldSpecInfo and lose ref * Change the number of issues * change to 1024 * move fields IndexError_Clear to main thread * remove rm_free(spec->fields); * fix * add header --------- Co-authored-by: Dor Forer <[email protected]> (cherry picked from commit d8b0313) * move our of coord macro --------- Co-authored-by: Dor Forer <[email protected]>
auto-merge was automatically disabled
May 26, 2025 05:32
Pull Request is not mergeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #6193 to
2.10