Skip to content

[8.0] [MOD-9396] Fix indexError leak #6206

Merged
meiravgri merged 1 commit into8.0from
backport-6193-to-8.0
May 26, 2025
Merged

[8.0] [MOD-9396] Fix indexError leak #6206
meiravgri merged 1 commit into8.0from
backport-6193-to-8.0

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented May 25, 2025

Description

Backport of #6193 to 8.0.

@meiravgri @dor-forer @github-actions
[MOD-9396] Fix indexError leak (#6193)
1e59086 
* free and invalidate NA_rstr (expect saniztizer to fail

* fix 1
should still leak on coordinator

* fix final leak - override AggregatedFieldSpecInfo and lose ref

* Change the number of issues

* change to 1024

* move fields IndexError_Clear to main thread

* remove rm_free(spec->fields);

* fix

* add header

---------

Co-authored-by: Dor Forer <[email protected]>
(cherry picked from commit d8b0313)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request May 25, 2025
Merged
@codecov
Copy link

codecov bot commented May 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.22%. Comparing base (638653d) to head (1e59086).
Report is 2 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/info/index_error.c 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              8.0    #6206      +/-   ##
==========================================
- Coverage   87.29%   87.22%   -0.07%     
==========================================
  Files         198      198              
  Lines       36165    36174       +9     
==========================================
- Hits        31569    31554      -15     
- Misses       4596     4620      +24
Flag Coverage Δ
flow 82.66% <94.44%> (-0.19%) ⬇️
unit 40.37% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue May 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 26, 2025
@meiravgri meiravgri added this pull request to the merge queue May 26, 2025
Merged via the queue into 8.0 with commit 9c491dc May 26, 2025
10 checks passed
@meiravgri meiravgri deleted the backport-6193-to-8.0 branch May 26, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meiravgri meiravgri meiravgri approved these changes

Assignees

No one assigned

Labels

size:S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@meiravgri