[MOD-5722] Build without readies [2.10]#6120
Merged
Conversation
working currently build only wip: - tests - coord
…env var is respected
build extension module always
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #6120 +/- ##
==========================================
- Coverage 87.23% 86.45% -0.79%
==========================================
Files 204 204
Lines 34654 34580 -74
==========================================
- Hits 30232 29895 -337
- Misses 4422 4685 +263
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports #6017 to the 2.10 branch and adjusts the build process to support two distinct build paths ("vanilla" and coordinator) as well as the REDISEARCH_MT_BUILD flag for multi-threading support.
- Modified shell and CMake scripts to correctly handle coordinator and MT build paths.
- Removed outdated Docker build files and updated workflow scripts to use custom build commands.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/pytests/runtests.sh | Enhanced module selection logic for coordinator builds. |
| tests/cpptests/CMakeLists.txt | Added conditional dependency for the example extension build. |
| sbin/unit-tests | Introduced stricter error handling and updated extension path settings. |
| coord/src/rmr/CMakeLists.txt | Updated include paths and added dependency ensuring libuv is built first. |
| coord/CMakeLists.txt | Improved coordinator-specific configuration and enabled MT build support. |
| build/s2geometry/Makefile.defs | Removed deprecated definitions in line with backport requirements. |
| build/s2geometry/Makefile | Removed as part of the backport cleanup. |
| build/hiredis/hiredis.cmake | Switched to an option for BUILD_SHARED_LIBS and refined linker flag settings. |
| build/docker/dockerfile.tmpl | Removed outdated dockerfile template. |
| build/docker/Makefile | Removed outdated Docker Makefile. |
| build/boost/boost.cmake | Added new CMake policies to support updated Boost behavior. |
| Makefile | Added coverage flag in the CMake command-line flags. |
| CMakeLists.txt | Revised build configuration with new helper functions and conditional flags. |
| .install/macos_update_profile.sh | Enhanced log output during PATH update. |
| .github/workflows/task-test.yml | Modified build commands and unit test invocation for improved clarity. |
| .github/workflows/benchmark-flow.yml | Updated build command parameters using a conditional expression. |
Comments suppressed due to low confidence (1)
.github/workflows/benchmark-flow.yml:58
- Verify that the conditional expression in the run command produces the expected result across all intended environments.
run: ./build.sh ${{ inputs.profile_env == 1 && 'PROFILE' || ''}}
| CLEAR_LOGS: 0 | ||
| ENABLE_ASSERT: 1 | ||
| run: make unit-tests | ||
| run: make unit-tests # todo: replace with ./build.sh RUN_UNIT_TESTS |
There was a problem hiding this comment.
Consider replacing 'make unit-tests' with './build.sh RUN_UNIT_TESTS' as indicated by the todo, to ensure consistency in the build process.
Contributor
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Comparison between 2.10 and remove_readies_2.10.Time Period from 30 days ago. (environment used: oss-standalone)
|
GuyAv46
approved these changes
May 18, 2025
alonre24
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Backport #6017 to 2.10.
There are some changes required in this backport due to the fact that 2.10 has two separate build paths - one for "vanilla" module and one for the coordinator build.
Also, on this branch, we have the "REDISEARCH_MT_BUILD" build flag that should be set to build with MT support.
Mark if applicable