MOD-9612: Do not check for early timeouts in non-strict timeout policy#6108
MOD-9612: Do not check for early timeouts in non-strict timeout policy#6108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6108 +/- ##
==========================================
- Coverage 87.19% 87.19% -0.01%
==========================================
Files 198 198
Lines 36051 36052 +1
==========================================
- Hits 31435 31434 -1
- Misses 4616 4618 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6108-to-2.8 origin/2.8
cd .worktree/backport-6108-to-2.8
git switch --create backport-6108-to-2.8
git cherry-pick -x 0e11efa39f21bf740ca741778b1a51b8ea11c3ef |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-6108-to-2.10 origin/2.10
cd .worktree/backport-6108-to-2.10
git switch --create backport-6108-to-2.10
git cherry-pick -x 0e11efa39f21bf740ca741778b1a51b8ea11c3ef |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-6108-to-8.0 origin/8.0
cd .worktree/backport-6108-to-8.0
git switch --create backport-6108-to-8.0
git cherry-pick -x 0e11efa39f21bf740ca741778b1a51b8ea11c3ef |
3 participants
This PR skips the early timeout check we perform between building the iterator tree and building the pipeline.
In this way - we will still fail early upon using the strict timeout policy, but will continue to fail (stop collecting results, and return the collected ones) a bit later in case of non-strict timeout policy.
Related #6100