Skip to content

Fix build for C23#6102

Merged
zeenix merged 2 commits intomasterfrom
fix-c++20-build
May 12, 2025
Merged

Fix build for C23#6102
zeenix merged 2 commits intomasterfrom
fix-c++20-build

Conversation

@zeenix
Copy link
Contributor

@zeenix zeenix commented May 7, 2025 •
edited
Loading

C23 is now the default in gcc (version 15) and is being shipped by default in some Linux distributions (e.g Fedora 42).

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.19%. Comparing base (b4b3074) to head (b0d40b6).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6102      +/-   ##
==========================================
- Coverage   87.22%   87.19%   -0.04%     
==========================================
  Files         198      198              
  Lines       36051    36051              
==========================================
- Hits        31446    31433      -13     
- Misses       4605     4618      +13
Flag Coverage Δ
flow 82.61% <0.00%> (-0.15%) ⬇️
unit 40.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zeenix
Copy link
Contributor Author

zeenix commented May 7, 2025

Just for the record, I ran this workflow to further test this doesn't break things for older compilers and it succeeds.

@zeenix zeenix requested review from kei-nan and raz-mon May 7, 2025 15:14
kei-nan
kei-nan reviewed May 8, 2025
View reviewed changes
@kei-nan
Copy link
Collaborator

kei-nan commented May 8, 2025

The title is a bit misleading - we are talking about c standard and not the c++ standard.

@zeenix
Copy link
Contributor Author

zeenix commented May 8, 2025

The title is a bit misleading - we are talking about c standard and not the c++ standard.

I thought that ATOMIC_VAR_INIT is purely a C++ API even though we're using it from C but seems you're right and this is because of C standard change. I'll update the title and commit log..

@zeenix zeenix changed the title Fix build for C++23 Fix build for C23 May 8, 2025
@zeenix
Fix build for C23
2d23d5d 
C23 is now the default in gcc (version 15) and is being shipped by
default in some Linux distributions (e.g Fedora 42).
@zeenix zeenix force-pushed the fix-c++20-build branch from 6ec63f0 to 2d23d5d Compare May 8, 2025 09:06
@zeenix zeenix enabled auto-merge May 8, 2025 09:37
raz-mon
raz-mon previously approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@raz-mon raz-mon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeenix Let's run the full CI on the PR (before merging or in the merge queue) just to see that all compilers of our supported versions "eat" this change fine

@zeenix zeenix added this pull request to the merge queue May 8, 2025
@zeenix zeenix removed this pull request from the merge queue due to a manual request May 8, 2025
@zeenix
Copy link
Contributor Author

zeenix commented May 8, 2025

@zeenix Let's run the full CI on the PR (before merging or in the merge queue) just to see that all compilers of our supported versions "eat" this change fine

For sure! 👍 How do you do that? :)

@zeenix
Copy link
Contributor Author

zeenix commented May 8, 2025

@raz-mon all good. 🥳

@zeenix zeenix added this pull request to the merge queue May 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2025
@github-actions github-actions bot added size:S and removed size:XS labels May 8, 2025
@kei-nan kei-nan added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@zeenix zeenix added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@zeenix zeenix added this pull request to the merge queue May 12, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 12, 2025
@zeenix
Fix build for C23 (#6102)
d302a48 
* Fix build for C23

C23 is now the default in gcc (version 15) and is being shipped by
default in some Linux distributions (e.g Fedora 42).

* Require C17
@zeenix zeenix mentioned this pull request May 12, 2025
Closed
@Itzikvaknin Itzikvaknin removed this pull request from the merge queue due to a manual request May 12, 2025
@zeenix zeenix added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit f2885df May 12, 2025
40 of 61 checks passed
@zeenix zeenix deleted the fix-c++20-build branch May 12, 2025 21:16
nafraf pushed a commit that referenced this pull request May 13, 2025
@zeenix @nafraf
Fix build for C23 (#6102)
a3a0b83 
* Fix build for C23

C23 is now the default in gcc (version 15) and is being shipped by
default in some Linux distributions (e.g Fedora 42).

* Require C17
JoanFM pushed a commit that referenced this pull request May 27, 2025
@zeenix @JoanFM
Fix build for C23 (#6102)
3fc86f8 
* Fix build for C23

C23 is now the default in gcc (version 15) and is being shipped by
default in some Linux distributions (e.g Fedora 42).

* Require C17
JoanFM pushed a commit that referenced this pull request May 27, 2025
@zeenix @JoanFM
Fix build for C23 (#6102)
ed3c7c3 
* Fix build for C23

C23 is now the default in gcc (version 15) and is being shipped by
default in some Linux distributions (e.g Fedora 42).

* Require C17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kei-nan kei-nan kei-nan approved these changes

@raz-mon raz-mon raz-mon left review comments

Assignees

No one assigned

Labels

size:S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeenix @kei-nan @raz-mon