Skip to content

[8.0] Skip Atempting to Load Key Name - [MOD-9419]#6021

Merged
GuyAv46 merged 1 commit into8.0from
backport-5959-to-8.0
Apr 27, 2025
Merged

[8.0] Skip Atempting to Load Key Name - [MOD-9419]#6021
GuyAv46 merged 1 commit into8.0from
backport-5959-to-8.0

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Apr 27, 2025

Description

Backport of #5959 to 8.0.

* implement new feature

* added a test

* reorder implementation

* fix test for master

* fix spells

* improve test

* review fixes

(cherry picked from commit b4ffb1a)
@GuyAv46 GuyAv46 added this pull request to the merge queue Apr 27, 2025
@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (3d81863) to head (ca5ab95).
Report is 1 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/result_processor.c 4.76% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #6021      +/-   ##
==========================================
- Coverage   87.27%   87.25%   -0.02%     
==========================================
  Files         206      206              
  Lines       36674    36695      +21     
==========================================
+ Hits        32007    32019      +12     
- Misses       4667     4676       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into 8.0 with commit 817f2ed Apr 27, 2025
9 of 10 checks passed
@GuyAv46 GuyAv46 deleted the backport-5959-to-8.0 branch April 27, 2025 10:18
GuyAv46 added a commit that referenced this pull request Apr 28, 2025
GuyAv46 added a commit that referenced this pull request Apr 28, 2025
DvirDukhan pushed a commit that referenced this pull request Apr 29, 2025
@DvirDukhan DvirDukhan restored the backport-5959-to-8.0 branch April 29, 2025 08:46
github-merge-queue bot pushed a commit that referenced this pull request Apr 29, 2025
Revert "[8.0] Skip Atempting to Load Key Name - [MOD-9419] (#6021)"

This reverts commit 817f2ed.

Co-authored-by: alonre24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants