[MOD-10144] Build with gcc-12 on amzn2#6019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6019 +/- ##
==========================================
- Coverage 88.77% 88.73% -0.04%
==========================================
Files 250 250
Lines 41497 41497
Branches 3632 3632
==========================================
- Hits 36837 36824 -13
- Misses 4611 4624 +13
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
print version in task test
.gitmodules
Outdated
| [submodule "deps/VectorSimilarity"] | ||
| path = deps/VectorSimilarity | ||
| url = https://github.com/RedisAI/VectorSimilarity.git | ||
| branch = main |
There was a problem hiding this comment.
should we perhaps have some marker of the VecSim related tests and have a separate set of tests dedicated to this?
Isn't there a big risk of blocking too many PR merges if there is a bug in main that one cannot fix here?
There was a problem hiding this comment.
redisearch is not going to point to vecsim main
This is a temporary change to allow me to utilize the CI to run against different platforms
meiravgri
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
3 participants
we are now using a container with a pre-built gcc/g++ 12 for amzn2.
on x86 it also installs a new assembler version to resolve all symbols.
NOTE
Once this pr is merged, amzn2 shared lib artifact will fail to link with redis in a cluster environment.
will be fixed ASAP!