Merged
Conversation
run unit tests with old "make unit-tests" way (until this is fixed via ./build.sh)
DvirDukhan
previously approved these changes
Apr 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Collaborator
Author
|
Fixed rust build for Alpine3, manual flow for Alpine: https://github.com/RediSearch/RediSearch/actions/runs/14739467466/job/41373645609 |
alonre24
requested review from
DvirDukhan and
GuyAv46
and removed request for
GuyAv46
GuyAv46
approved these changes
Apr 30, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6017-to-2.8 origin/2.8
cd .worktree/backport-6017-to-2.8
git switch --create backport-6017-to-2.8
git cherry-pick -x bd569209494b0afa76256e9211f20ebf1ce353d7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-6017-to-2.6 origin/2.6
cd .worktree/backport-6017-to-2.6
git switch --create backport-6017-to-2.6
git cherry-pick -x bd569209494b0afa76256e9211f20ebf1ce353d7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-6017-to-2.10 origin/2.10
cd .worktree/backport-6017-to-2.10
git switch --create backport-6017-to-2.10
git cherry-pick -x bd569209494b0afa76256e9211f20ebf1ce353d7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-6017-to-8.0 origin/8.0
cd .worktree/backport-6017-to-8.0
git switch --create backport-6017-to-8.0
git cherry-pick -x bd569209494b0afa76256e9211f20ebf1ce353d7 |
2 tasks
nafraf
pushed a commit
that referenced
this pull request
May 13, 2025
* purge readeis from cmake. Use new build script instead of makefile * call script in CI * libuv * restore build folder * libuv * unit tests * pretty build.sh * pytest * fixed extension build error * Add profile flags + try pass linker flag properly (wip) * fix build and linkage + pytest + adjust json * small cleanup * Add pytz dep * bump googletest version, use same variant name as before * remove ld libs * Fix executable linker flags - build unit test properly. run unit tests with old "make unit-tests" way (until this is fixed via ./build.sh) * fix rust build via build.sh * fix san build * Set coverage flags and use the same bin dir for sanitizer (build it for debug) * update benchmark image for regression test * remove leftover * Build hiredis static * fix json env flag in CI * CR changes * Restore deleted files until unit tests are done as well, use boolean params * restore vecsim version * fix profile and fix build error * fix for profile * try fix mac build * fix unit tests for arm * Define boost dir * remove the policies * try fix the binroot for unit-tests * change dir name for arm * remove policy from hash as well * use clang in mac * try to set hardcoded clang * try to mimic readies in macos includes * try set CMAKE_OSX_DEPLOYMENT_TARGET * whitespace formatting * Set CC to clang in apple * try to export llvm * try set compiler in build script * use bin in path * try EXPORT properly with homebrew * remove setting bad path to clang * set clang path * update to llvm@18 * update c++ path * set compiler with LLVM env var * fix? * set proper link flags for mac * remove bsymbolic from hiredis * revert hiredis in non macos to how it was * clean stuff * cleanups * Fix the extract debug symbols command so it will work as before (required for packing properly) * update deps * fix for alpine --------- Co-authored-by: DvirDukhan <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
alonre24
changed the title
2 tasks
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* purge readeis from cmake. Use new build script instead of makefile * call script in CI * libuv * restore build folder * libuv * unit tests * pretty build.sh * pytest * fixed extension build error * Add profile flags + try pass linker flag properly (wip) * fix build and linkage + pytest + adjust json * small cleanup * Add pytz dep * bump googletest version, use same variant name as before * remove ld libs * Fix executable linker flags - build unit test properly. run unit tests with old "make unit-tests" way (until this is fixed via ./build.sh) * fix rust build via build.sh * fix san build * Set coverage flags and use the same bin dir for sanitizer (build it for debug) * update benchmark image for regression test * remove leftover * Build hiredis static * fix json env flag in CI * CR changes * Restore deleted files until unit tests are done as well, use boolean params * restore vecsim version * fix profile and fix build error * fix for profile * try fix mac build * fix unit tests for arm * Define boost dir * remove the policies * try fix the binroot for unit-tests * change dir name for arm * remove policy from hash as well * use clang in mac * try to set hardcoded clang * try to mimic readies in macos includes * try set CMAKE_OSX_DEPLOYMENT_TARGET * whitespace formatting * Set CC to clang in apple * try to export llvm * try set compiler in build script * use bin in path * try EXPORT properly with homebrew * remove setting bad path to clang * set clang path * update to llvm@18 * update c++ path * set compiler with LLVM env var * fix? * set proper link flags for mac * remove bsymbolic from hiredis * revert hiredis in non macos to how it was * clean stuff * cleanups * Fix the extract debug symbols command so it will work as before (required for packing properly) * update deps * fix for alpine --------- Co-authored-by: DvirDukhan <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* purge readeis from cmake. Use new build script instead of makefile * call script in CI * libuv * restore build folder * libuv * unit tests * pretty build.sh * pytest * fixed extension build error * Add profile flags + try pass linker flag properly (wip) * fix build and linkage + pytest + adjust json * small cleanup * Add pytz dep * bump googletest version, use same variant name as before * remove ld libs * Fix executable linker flags - build unit test properly. run unit tests with old "make unit-tests" way (until this is fixed via ./build.sh) * fix rust build via build.sh * fix san build * Set coverage flags and use the same bin dir for sanitizer (build it for debug) * update benchmark image for regression test * remove leftover * Build hiredis static * fix json env flag in CI * CR changes * Restore deleted files until unit tests are done as well, use boolean params * restore vecsim version * fix profile and fix build error * fix for profile * try fix mac build * fix unit tests for arm * Define boost dir * remove the policies * try fix the binroot for unit-tests * change dir name for arm * remove policy from hash as well * use clang in mac * try to set hardcoded clang * try to mimic readies in macos includes * try set CMAKE_OSX_DEPLOYMENT_TARGET * whitespace formatting * Set CC to clang in apple * try to export llvm * try set compiler in build script * use bin in path * try EXPORT properly with homebrew * remove setting bad path to clang * set clang path * update to llvm@18 * update c++ path * set compiler with LLVM env var * fix? * set proper link flags for mac * remove bsymbolic from hiredis * revert hiredis in non macos to how it was * clean stuff * cleanups * Fix the extract debug symbols command so it will work as before (required for packing properly) * update deps * fix for alpine --------- Co-authored-by: DvirDukhan <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
(PR started by @DvirDukhan, continue by @alonre24). Original PR was merged and reverted due to packing failures #6003)
The goal is to purge https://github.com/RedisLabsModules/readies from our build system.
In this PR we introduce a new script
.build.shwhich is an alternative entry point for building the module usingcmakewithout going through the makefile.This includes refactoring of our CMakeLists.txt so it will account for the rules and flags that are passed via readies.
Now we can to the following operations without going through readies:
./build.sh [TESTS]./build.sh RUN_PYTEST./build.sh [RUN_PYTEST]This is still an intermediate step on the way to purge readies, and building the module in the "old way" using
makefilerules is still possible (and will probably be available in the future as well, but internally will call to./build.sh- TBD).As part of that, I also:
** Benchmarks flow does not show any regression **
Left to do (in upcoming PRs):
make coveragecall only.make unit-testsMark if applicable