[2.8] Improve parser for intersections [MOD-9278]#6008
Merged
Conversation
* improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above (cherry picked from commit 7c195ee)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6008 +/- ##
==========================================
+ Coverage 85.83% 86.10% +0.27%
==========================================
Files 199 201 +2
Lines 34235 34539 +304
==========================================
+ Hits 29386 29741 +355
+ Misses 4849 4798 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kei-nan
previously approved these changes
Apr 24, 2025
kei-nan
approved these changes
Apr 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5984 to
2.8.