Skip to content

Revert "Refactor build system - remove readies from module build"#6003

Merged
alonre24 merged 1 commit intomasterfrom
revert_purge_redies
Apr 23, 2025
Merged

Revert "Refactor build system - remove readies from module build"#6003
alonre24 merged 1 commit intomasterfrom
revert_purge_redies

Conversation

@alonre24
Copy link
Collaborator

Describe the changes in the pull request

Rverting #5737 as it failed on packing artifacts

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@alonre24 alonre24 requested a review from GuyAv46 April 23, 2025 16:23
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@alonre24 alonre24 enabled auto-merge April 23, 2025 16:25
@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (7c195ee) to head (a06c4a2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6003      +/-   ##
==========================================
- Coverage   87.24%   87.08%   -0.17%     
==========================================
  Files         197      211      +14     
  Lines       36012    38590    +2578     
  Branches        0     1893    +1893     
==========================================
+ Hits        31420    33605    +2185     
- Misses       4592     4978     +386     
- Partials        0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alonre24 alonre24 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into master with commit 5bc999e Apr 23, 2025
11 checks passed
@alonre24 alonre24 deleted the revert_purge_redies branch April 23, 2025 17:48
@alonre24 alonre24 mentioned this pull request Apr 25, 2025
9 tasks
JoanFM pushed a commit that referenced this pull request May 27, 2025
)

Revert "Refactor build system - remove readies from module build [MOD-5722] (#5737)"

This reverts commit 39fcd2c.
JoanFM pushed a commit that referenced this pull request May 27, 2025
)

Revert "Refactor build system - remove readies from module build [MOD-5722] (#5737)"

This reverts commit 39fcd2c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants