Avoid lazy expiration in background indexing for CRDT [MOD-9486]#6002
Merged
Avoid lazy expiration in background indexing for CRDT [MOD-9486]#6002
Conversation
lerman25
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6002 +/- ##
==========================================
- Coverage 88.24% 88.21% -0.04%
==========================================
Files 220 220
Lines 39516 39516
Branches 2780 2780
==========================================
- Hits 34871 34858 -13
- Misses 4636 4649 +13
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Did we validate it with the CRDT team? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in background indexing for CRDT by ensuring that keys opened for CRDT are always opened with the proper flags to avoid lazy expiration.
- Update condition to force reopening keys for CRDT using the 'noeffect' flag.
- Adjust comment text and order to improve clarity around document type checking and key closing.
…pire-CRDT-crdtOnly
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the lazy expiration issue during background indexing for CRDT by ensuring that keys for CRDT are always opened with the noeffect flag, avoiding side effects during type checks. The key changes include:
- Updating the conditional to re-open the key if operating on CRDT.
- Rearranging the document type check to occur after closing the key when necessary.
- Modifying comments to better describe the steps in key handling for indexing.
Comments suppressed due to low confidence (1)
src/spec.c:2236
- The updated conditional re-opens the key when 'isCrdt' is true, even if 'key' is already non-null. Please verify that this behavior is intended and add a comment clarifying that re-opening is necessary to apply the 'noeffect' flag for CRDT keys.
if (!key || isCrdt) {
alonre24
approved these changes
Apr 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6002-to-2.8 origin/2.8
cd .worktree/backport-6002-to-2.8
git switch --create backport-6002-to-2.8
git cherry-pick -x 17193a5eed07f2bc43cb3fdfa4166f9466277209 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-6002-to-2.6 origin/2.6
cd .worktree/backport-6002-to-2.6
git switch --create backport-6002-to-2.6
git cherry-pick -x 17193a5eed07f2bc43cb3fdfa4166f9466277209 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-6002-to-2.10 origin/2.10
cd .worktree/backport-6002-to-2.10
git switch --create backport-6002-to-2.10
git cherry-pick -x 17193a5eed07f2bc43cb3fdfa4166f9466277209 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
* fix leak + open alawys on crdt * complete comment * format (cherry picked from commit 17193a5)
Contributor
|
Successfully created backport PR for |
lerman25
added a commit
that referenced
this pull request
Apr 29, 2025
* fix leak + open alawys on crdt * complete comment * format (cherry picked from commit 17193a5)
lerman25
added a commit
that referenced
this pull request
Apr 29, 2025
* fix leak + open alawys on crdt * complete comment * format (cherry picked from commit 17193a5)
lerman25
added a commit
that referenced
this pull request
Apr 29, 2025
* fix leak + open alawys on crdt * complete comment * format (cherry picked from commit 17193a5)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
#6055) Avoid lazy expiration in background indexing for CRDT [MOD-9486] (#6002) * fix leak + open alawys on crdt * complete comment * format (cherry picked from commit 17193a5) Co-authored-by: lerman25 <[email protected]>
nafraf
pushed a commit
that referenced
this pull request
May 13, 2025
* fix leak + open alawys on crdt * complete comment * format
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* fix leak + open alawys on crdt * complete comment * format
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* fix leak + open alawys on crdt * complete comment * format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, during the background scan, using RM_KeyType to check the key type causes the key to expire in CRDT, due to CRDT's RM_KeyType function.
To solve, if we are on crdt, we open the key in the scan with the noeffect flag.
This continues the work from #5274.