Closed
Conversation
5f3cd71 to
830d3a5
Compare
DarthB
reviewed
Apr 23, 2025
DarthB
reviewed
Apr 24, 2025
39ada36 to
d85db90
Compare
DarthB
reviewed
Apr 24, 2025
DarthB
reviewed
Apr 24, 2025
DarthB
reviewed
Apr 24, 2025
Contributor
|
We should rebase on master again - the changes in a0fb945 change the structure for our ffi modules (all are moved to the redissearch_rs crate) |
DarthB
reviewed
Apr 28, 2025
6fb43c2 to
6c7b96e
Compare
ef433f5 to
63b7535
Compare
fcc00a1 to
baafa85
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5996 +/- ##
==========================================
- Coverage 87.23% 87.17% -0.07%
==========================================
Files 198 196 -2
Lines 36052 35968 -84
==========================================
- Hits 31449 31354 -95
- Misses 4603 4614 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
C23 is now the default in gcc (version 15) and is being shipped by default in some Linux distributions (e.g Fedora 42).
369fa76 to
c6210b5
Compare
Contributor
Author
Collaborator
|
Let's split this PR in 3 smaller ones:
|
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
varintmodule is currently in C.varintmodule to Rust, along with adding a more idiomatic Rust API.