Improve parser for intersections [MOD-9278]#5984
Merged
Conversation
kei-nan
reviewed
Apr 22, 2025
kei-nan
reviewed
Apr 22, 2025
kei-nan
reviewed
Apr 22, 2025
kei-nan
reviewed
Apr 22, 2025
kei-nan
reviewed
Apr 22, 2025
kei-nan
reviewed
Apr 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5984 +/- ##
==========================================
- Coverage 87.08% 87.05% -0.04%
==========================================
Files 211 211
Lines 38595 38590 -5
Branches 1893 1893
==========================================
- Hits 33610 33594 -16
- Misses 4978 4989 +11
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kei-nan
reviewed
Apr 22, 2025
kei-nan
previously approved these changes
Apr 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kei-nan
reviewed
Apr 23, 2025
kei-nan
reviewed
Apr 23, 2025
kei-nan
approved these changes
Apr 23, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5984-to-2.8 origin/2.8
cd .worktree/backport-5984-to-2.8
git switch --create backport-5984-to-2.8
git cherry-pick -x 7c195eeb51daa5b11bfac7d0472387a6e4ddb041 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5984-to-2.6 origin/2.6
cd .worktree/backport-5984-to-2.6
git switch --create backport-5984-to-2.6
git cherry-pick -x 7c195eeb51daa5b11bfac7d0472387a6e4ddb041 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5984-to-2.10 origin/2.10
cd .worktree/backport-5984-to-2.10
git switch --create backport-5984-to-2.10
git cherry-pick -x 7c195eeb51daa5b11bfac7d0472387a6e4ddb041 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5984-to-8.0 origin/8.0
cd .worktree/backport-5984-to-8.0
git switch --create backport-5984-to-8.0
git cherry-pick -x 7c195eeb51daa5b11bfac7d0472387a6e4ddb041 |
GuyAv46
added a commit
that referenced
this pull request
Apr 23, 2025
* improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above (cherry picked from commit 7c195ee)
GuyAv46
added a commit
that referenced
this pull request
Apr 24, 2025
* improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above (cherry picked from commit 7c195ee)
GuyAv46
added a commit
that referenced
this pull request
Apr 24, 2025
* improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above (cherry picked from commit 7c195ee)
This was referenced Apr 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 27, 2025
* Improve parser for intersections [MOD-9278] (#5984) * improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above (cherry picked from commit 7c195ee) * fix config call for 2.8 * fix config command in test * fix another test for 2.8
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 27, 2025
* Improve parser for intersections [MOD-9278] (#5984) * improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above (cherry picked from commit 7c195ee) * fix config call for 2.6 * fix config command in test
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* improve intersection node parsing * refactor `one_not_null` * WIP test * complete test * reorder for a clearer diff * review fixes * fix spellcheck * fix tests for dialect 2 and above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Improve intersection parsing (
DIALECT 2and above) so parentheses and sub-queries order won't affect text scoresMark if applicable