Skip to content

[2.8] Fix scores when document has no text - [MOD-9423]#5966

Merged
GuyAv46 merged 3 commits into2.8from
backport-5958-to-2.8
Apr 27, 2025
Merged

[2.8] Fix scores when document has no text - [MOD-9423]#5966
GuyAv46 merged 3 commits into2.8from
backport-5958-to-2.8

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Apr 20, 2025

Description

Backport of #5958 to 2.8.

* fix scorers

* add a test

(cherry picked from commit 3588904)
@GuyAv46 GuyAv46 added the bug label Apr 20, 2025
@GuyAv46 GuyAv46 requested review from kei-nan and raz-mon April 20, 2025 16:59
@GuyAv46 GuyAv46 enabled auto-merge April 20, 2025 16:59
@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (aea3e7a) to head (1c70f12).
Report is 5 commits behind head on 2.8.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.8    #5966   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files         201      201           
  Lines       34546    34549    +3     
=======================================
+ Hits        29745    29750    +5     
+ Misses       4801     4799    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

raz-mon
raz-mon previously approved these changes Apr 20, 2025
kei-nan
kei-nan previously approved these changes Apr 21, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Apr 27, 2025
Merged via the queue into 2.8 with commit f08478e Apr 27, 2025
9 checks passed
@GuyAv46 GuyAv46 deleted the backport-5958-to-2.8 branch April 27, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants