Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5941 +/- ##
==========================================
- Coverage 87.09% 87.06% -0.04%
==========================================
Files 211 211
Lines 38565 38565
Branches 1893 1893
==========================================
- Hits 33588 33575 -13
- Misses 4970 4983 +13
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
reviewed
Apr 15, 2025
GuyAv46
approved these changes
Apr 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
* fix flaky * comment * change to ceil (cherry picked from commit 358b845)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
fix flaky OOM tests MOD-9406 (#5941) * fix flaky * comment * change to ceil (cherry picked from commit 358b845) Co-authored-by: lerman25 <[email protected]>
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* fix flaky * comment * change to ceil
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* fix flaky * comment * change to ceil
lerman25
added a commit
that referenced
this pull request
Jun 5, 2025
* fix flaky * comment * change to ceil
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
* MOD-8862: Add DebugCTX mechanism and DebugIndexesScanner (#5672) * Create dbg ctx and dbgIndScan * Fix * fixing mechanism and pytest * Add pause before scan mechanism and pytest * Revert "Add pause before scan mechanism and pytest" This reverts commit b842ce9. * Re-adding 'Add pause before scan mechanism and pytest' * fix testDebugHelp * fixing Guy's comment + skipping on cluster in pytest * Move volatile pause to BG scanner, move debug scanner flag to base IndexesScanner * fix pytest * thread safety * Cover more code * pause before scan coverage * fix - can't create a flow to reach 'Debug mode enabled but scanner is not a debug scanner' error * fixing Alon's comment * wrong arity check and comment on not used function * format * MOD-7795: Background indexing memory limitation & configuration * fix test * fix-test2 * fix flaky OOM tests MOD-9406 (#5941) * fix flaky * comment * change to ceil * [MOD-9560] Change default config value for _BG_INDEX_MEM_PCT_THR (#6053) * change default value * change default value in config pytest * change index oom tests to lower value then new default * change debug commands tests to lower value then default value * change default value of set tight memory functions * 100testv1 * test default value * [MOD-9560] Change default config value for _BG_INDEX_MEM_PCT_THR * fix json * [MOD-9372 , MOD-9733] Stop indexing OOM - Add wait before OOM * skip query error test * fix typo * support different default values * change test config * fix config * skip non cluster * [MOD-9560] Revert marking index as faulty after reaching OOM * [MOD-9372] - Add GIL release in OOM wait * remove cargo * fix pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flakiness of OOM testing by setting tighter limits.