[2.8] Simplify upload artifacts [MOD-6152] (#5905)#5935
Merged
Conversation
* Change to inline script * Change pipeline to bash * Move to test deps * Try platform * change the script * test * Change to inline script * Change pipeline to bash * Move to test deps * Try platform * change the script * test * old * add * remove * check that file was uploaded * Fix prints * Add the script * Add group print * Remove comments * Fix the spell check * fix * Change the help * add menu * makefile changes * snapshots * change the makefile * change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #5935 +/- ##
=======================================
Coverage 86.10% 86.11%
=======================================
Files 201 201
Lines 34550 34546 -4
=======================================
- Hits 29751 29748 -3
+ Misses 4799 4798 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
reviewed
Apr 15, 2025
sbin/upload-artifacts
Outdated
| PROD=redisearch PREFIX=redisearch-light s3_upload | ||
| PROD=redisearch-oss PREFIX=redisearch-oss s3_upload | ||
| # Main upload process | ||
| upload_product "redisearch-community" "redisearch-oss" "redisearch-community" |
Collaborator
There was a problem hiding this comment.
where/how are we uploading enterprise/light builds?
GuyAv46
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #5905 to 2.8
https://github.com/RediSearch/RediSearch/actions/runs/14487931027