VecSim Info API update and ARM Optimizations - [MOD-9354]#5911
Merged
VecSim Info API update and ARM Optimizations - [MOD-9354]#5911
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5911 +/- ##
==========================================
- Coverage 87.08% 87.05% -0.04%
==========================================
Files 211 211
Lines 38569 38565 -4
Branches 1893 1893
==========================================
- Hits 33589 33573 -16
- Misses 4973 4985 +12
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
previously approved these changes
Apr 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lerman25
approved these changes
Apr 15, 2025
GuyAv46
changed the title
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5911-to-2.8 origin/2.8
cd .worktree/backport-5911-to-2.8
git switch --create backport-5911-to-2.8
git cherry-pick -x 383ed64b5a4332a5dfe7ced3202dffc2260a15fd |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5911-to-2.6 origin/2.6
cd .worktree/backport-5911-to-2.6
git switch --create backport-5911-to-2.6
git cherry-pick -x 383ed64b5a4332a5dfe7ced3202dffc2260a15fd |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5911-to-2.10 origin/2.10
cd .worktree/backport-5911-to-2.10
git switch --create backport-5911-to-2.10
git cherry-pick -x 383ed64b5a4332a5dfe7ced3202dffc2260a15fd |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64)
Contributor
|
Successfully created backport PR for |
GuyAv46
added a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64)
GuyAv46
added a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64)
GuyAv46
added a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64)
This was referenced Apr 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
Use new info API of VecSim for metrics [MOD-9354] (#5911) * Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64) Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of VecSim for metrics [MOD-9354] (#5911) * Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64) * fixes for 2.8 --------- Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of VecSim for metrics [MOD-9354] (#5911) * Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64) * fixes for 2.6 --------- Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of VecSim for metrics [MOD-9354] (#5911) * Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64) * fixes for 2.10 * Revert "[MOD-9313] Disable extended vecsim info [2.10] (#5893)" This reverts commit 6c4884c. --------- Co-authored-by: alonre24 <[email protected]>
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]>
JoanFM
pushed a commit
that referenced
this pull request
May 27, 2025
* Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
infothat is also used to generate metrics. This way, we are using a safe and fast API that does not use any locks.Mark if applicable