Skip to content

Simplify upload artifacts [MOD-6152]#5905

Merged
dor-forer merged 31 commits intomasterfrom
dorer-simplify-upload-artifacts_MOD-6152
Apr 10, 2025
Merged

Simplify upload artifacts [MOD-6152]#5905
dor-forer merged 31 commits intomasterfrom
dorer-simplify-upload-artifacts_MOD-6152

Conversation

@dor-forer
Copy link
Collaborator

@dor-forer dor-forer commented Apr 10, 2025

Describe the changes in the pull request

  1. upload-artifacts script:
  • Remove unused options.
  • Make the upload process more informative.
  • Remove the readies use
  1. Added new get-platform script (Created by @lerman25

Main objects this PR modified

  1. upload-artifacts script.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (7bdc989) to head (5184d84).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5905      +/-   ##
==========================================
+ Coverage   87.05%   87.08%   +0.03%     
==========================================
  Files         211      211              
  Lines       38453    38569     +116     
  Branches     1893     1893              
==========================================
+ Hits        33475    33588     +113     
- Misses       4971     4974       +3     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dor-forer dor-forer requested a review from alonre24 April 10, 2025 08:49
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
Please verify the flow manually again before merging

@dor-forer dor-forer added this pull request to the merge queue Apr 10, 2025
Merged via the queue into master with commit d8a2af3 Apr 10, 2025
41 checks passed
@dor-forer dor-forer deleted the dorer-simplify-upload-artifacts_MOD-6152 branch April 10, 2025 16:00
@lerman25
Copy link
Collaborator

/backport

@redisearch-backport-pull-request
Copy link
Contributor

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-5905-to-2.8 origin/2.8
cd .worktree/backport-5905-to-2.8
git switch --create backport-5905-to-2.8
git cherry-pick -x d8a2af313c40575bb9fb7376e7571e2e6afe0397

@redisearch-backport-pull-request
Copy link
Contributor

Backport failed for 2.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.6
git worktree add -d .worktree/backport-5905-to-2.6 origin/2.6
cd .worktree/backport-5905-to-2.6
git switch --create backport-5905-to-2.6
git cherry-pick -x d8a2af313c40575bb9fb7376e7571e2e6afe0397

@redisearch-backport-pull-request
Copy link
Contributor

Backport failed for 2.10, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.10
git worktree add -d .worktree/backport-5905-to-2.10 origin/2.10
cd .worktree/backport-5905-to-2.10
git switch --create backport-5905-to-2.10
git cherry-pick -x d8a2af313c40575bb9fb7376e7571e2e6afe0397

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Apr 14, 2025
* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change

(cherry picked from commit d8a2af3)
@redisearch-backport-pull-request
Copy link
Contributor

Successfully created backport PR for 8.0:

lerman25 pushed a commit that referenced this pull request Apr 15, 2025
* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change
lerman25 pushed a commit that referenced this pull request Apr 15, 2025
* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change
lerman25 pushed a commit that referenced this pull request Apr 15, 2025
* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change
github-merge-queue bot pushed a commit that referenced this pull request Apr 15, 2025
Simplify upload artifacts [MOD-6152] (#5905)

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change

(cherry picked from commit d8a2af3)

Co-authored-by: dor-forer <[email protected]>
@GuyAv46 GuyAv46 mentioned this pull request Apr 15, 2025
2 tasks
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2025
* Simplify upload artifacts [MOD-6152] (#5905)

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change

* fix

---------

Co-authored-by: dor-forer <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2025
* Simplify upload artifacts [MOD-6152] (#5905)

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change

* fix

---------

Co-authored-by: dor-forer <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2025
* Simplify upload artifacts [MOD-6152] (#5905)

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change

* fix

* remove SNAPSHOTS_FOLDER

---------

Co-authored-by: dor-forer <[email protected]>
JoanFM pushed a commit that referenced this pull request May 27, 2025
* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change
JoanFM pushed a commit that referenced this pull request May 27, 2025
* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* Change to inline script

* Change pipeline to bash

* Move to test deps

* Try platform

* change the script

* test

* old

* add

* remove

* check that file was uploaded

* Fix prints

* Add the script

* Add group print

* Remove comments

* Fix the spell check

* fix

* Change the help

* add menu

* makefile changes

* snapshots

* change the makefile

* change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants