[MOD-9313] Disable extended vecsim info [2.10]#5893
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #5893 +/- ##
==========================================
- Coverage 86.67% 86.64% -0.04%
==========================================
Files 201 201
Lines 34443 34440 -3
==========================================
- Hits 29853 29840 -13
- Misses 4590 4600 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
previously approved these changes
Apr 9, 2025
Collaborator
GuyAv46
left a comment
GuyAv46
left a comment
There was a problem hiding this comment.
Don’t forget to link the other PRs when you open them
nafraf
reviewed
Apr 9, 2025
GuyAv46
approved these changes
Apr 9, 2025
DvirDukhan
approved these changes
Apr 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
* Use new info API of VecSim for metrics [MOD-9354] (#5911) * Use new info API of vecsim * change to fixed main * attempt to fix a test * fix * another attempt * another attempt * fix type and add info to test_hybrid_query_with_geo * another attempt * finalize test fix * update vecsim tag --------- Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 383ed64) * fixes for 2.10 * Revert "[MOD-9313] Disable extended vecsim info [2.10] (#5893)" This reverts commit 6c4884c. --------- Co-authored-by: alonre24 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Temporarily disable
search_used_memory_vector_indexandsearch_marked_deleted_vectorsmetrics, as they rely onVecSimIndex_Infocall over a tiered index, which is an api designed for debug operation and not for production since it may be time consuming.The fix will come shortly to all branches in a different PR.
Mark if applicable