[2.8] MOD-9174: Fix pipeline issues (#5837)#5863
Merged
Conversation
* Fix pager query resultLimit setting to initialization time * Change fix to call Next in safeLoader again * Enhance comment * wip * Fix safe-loader to not deplete the pipeline on first call * Fix test * Address review * Remove all of resultLimit in Pager * Revert "Remove all of resultLimit in Pager" This reverts commit 142aca0.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #5863 +/- ##
==========================================
- Coverage 86.10% 86.09% -0.01%
==========================================
Files 201 201
Lines 34535 34546 +11
==========================================
+ Hits 29735 29742 +7
- Misses 4800 4804 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
previously approved these changes
Apr 3, 2025
GuyAv46
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP of #5837 to
2.8.