Skip to content

[8.0] MOD-9174: Fix pipeline issues (#5837)#5857

Merged
raz-mon merged 1 commit into8.0from
razmon-cp_8.0_pipeline_issues
Apr 20, 2025
Merged

[8.0] MOD-9174: Fix pipeline issues (#5837)#5857
raz-mon merged 1 commit into8.0from
razmon-cp_8.0_pipeline_issues

Conversation

@raz-mon
Copy link
Collaborator

@raz-mon raz-mon commented Apr 2, 2025

CP of #5837 to 8.0
One conflict in result_processor.h, relating to the un-backported initTime, GILTime fields.

* Fix pager query resultLimit setting to initialization time

* Change fix to call Next in safeLoader again

* Enhance comment

* wip

* Fix safe-loader to not deplete the pipeline on first call

* Fix test

* Address review

* Remove all of resultLimit in Pager

* Revert "Remove all of resultLimit in Pager"

This reverts commit 142aca0.
@raz-mon raz-mon requested a review from kei-nan April 2, 2025 07:15
@DvirDukhan
Copy link

@raz-mon please merge after GA

@raz-mon raz-mon removed the request for review from kei-nan April 2, 2025 07:32
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (ffdd0cb) to head (5f8ffca).
Report is 17 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/result_processor.c 25.00% 6 Missing ⚠️
src/aggregate/aggregate_exec.c 60.00% 2 Missing ⚠️
src/module.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #5857      +/-   ##
==========================================
- Coverage   87.28%   87.27%   -0.02%     
==========================================
  Files         206      206              
  Lines       36519    36529      +10     
==========================================
+ Hits        31875    31880       +5     
- Misses       4644     4649       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raz-mon raz-mon added this pull request to the merge queue Apr 20, 2025
Merged via the queue into 8.0 with commit a6ba46c Apr 20, 2025
7 of 8 checks passed
@raz-mon raz-mon deleted the razmon-cp_8.0_pipeline_issues branch April 20, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants