[2.10] MOD-9054: Fix total_results field in shard RESP3 response (#5765)#5804
Merged
[2.10] MOD-9054: Fix total_results field in shard RESP3 response (#5765)#5804
total_results field in shard RESP3 response (#5765)#5804Conversation
* Remove redundant condition * Return correct number of results in FT.AGGREGATE + RESP3 * Remove redundant condition in RESP2 response path * Add test * Add cursor test * Fix spelling error * Fix test
kei-nan
reviewed
Mar 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #5804 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 198 198
Lines 34273 34269 -4
=======================================
- Hits 29690 29687 -3
+ Misses 4583 4582 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kei-nan
approved these changes
Mar 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP of #5765 to
2.10