Skip to content

[2.8] MOD-5904: Fix DocTable memsize (#5099)#5801

Merged
nafraf merged 2 commits into2.8from
nafraf_backport-5099-to-2.8
Mar 26, 2025
Merged

[2.8] MOD-5904: Fix DocTable memsize (#5099)#5801
nafraf merged 2 commits into2.8from
nafraf_backport-5099-to-2.8

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented Mar 20, 2025

Description

Manual backport of #5099 to 2.8.
(cherry picked from commit b4234ed)

Adjustments for 2.8

  • 2.8 does not contain tests/cpptests/test_cpp_llapi.cpp: TEST_F(LLApiTest, testInfoSizeWithExistingIndex)
  • sizeof(DocTable) = 64 bytes, because does not contain TimeToLiveTable* ttl;

@nafraf nafraf marked this pull request as ready for review March 20, 2025 00:48
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (eb7efa6) to head (c9c59bd).
Report is 5 commits behind head on 2.8.

Files with missing lines Patch % Lines
src/doc_table.c 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #5801      +/-   ##
==========================================
- Coverage   86.06%   86.05%   -0.01%     
==========================================
  Files         200      200              
  Lines       34386    34393       +7     
==========================================
+ Hits        29593    29596       +3     
- Misses       4793     4797       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nafraf nafraf requested review from kei-nan, oshadmi and raz-mon March 21, 2025 12:18
@nafraf nafraf added this pull request to the merge queue Mar 26, 2025
Merged via the queue into 2.8 with commit ea35c71 Mar 26, 2025
11 of 14 checks passed
@nafraf nafraf deleted the nafraf_backport-5099-to-2.8 branch March 26, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants