[8.0] MOD-9054: Fix total_results field in shard RESP3 response#5795
Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.0from Mar 19, 2025
Merged
[8.0] MOD-9054: Fix total_results field in shard RESP3 response#5795redisearch-backport-pull-request[bot] merged 1 commit into8.0from
total_results field in shard RESP3 response#5795redisearch-backport-pull-request[bot] merged 1 commit into8.0from
Conversation
* Remove redundant condition * Return correct number of results in FT.AGGREGATE + RESP3 * Remove redundant condition in RESP2 response path * Add test * Add cursor test * Fix spelling error * Fix test (cherry picked from commit 19504b6)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5795 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 200 200
Lines 36035 36031 -4
=======================================
- Hits 31733 31731 -2
+ Misses 4302 4300 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
raz-mon
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5765 to
8.0.