[2.10] [MOD-9023] Replacing freeFlag with a reference counter#5784
Merged
[2.10] [MOD-9023] Replacing freeFlag with a reference counter#5784
Conversation
* add prints * fix * no depletion in getCursorCommand * add info to assert * free flag is now a ref counter to avoid potential race condition where one side is changing it twice. The refcount is increased when a new job is pushed to the queue, and decreased when the coordinator doesn't need any replies, or when all readers have done executing the job. introduce logging capabilities when ENABLE_ASSERT=1 : RS_DEBUG_LOG and RS_DEBUG_LOG_FMT to log in debug level * cleanups * cr (cherry picked from commit 3420e93)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #5784 +/- ##
==========================================
- Coverage 86.62% 86.62% -0.01%
==========================================
Files 198 198
Lines 34273 34273
==========================================
- Hits 29690 29689 -1
- Misses 4583 4584 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Mar 18, 2025
Collaborator
Author
|
/backport |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5784-to-2.8 origin/2.8
cd .worktree/backport-5784-to-2.8
git switch --create backport-5784-to-2.8
git cherry-pick -x 607a11854beeedcd9a38d557e5400d6a820c21be |
meiravgri
added a commit
that referenced
this pull request
Mar 20, 2025
[MOD-9023] Replacing freeFlag with a reference counter (#5736) * add prints * fix * no depletion in getCursorCommand * add info to assert * free flag is now a ref counter to avoid potential race condition where one side is changing it twice. The refcount is increased when a new job is pushed to the queue, and decreased when the coordinator doesn't need any replies, or when all readers have done executing the job. introduce logging capabilities when ENABLE_ASSERT=1 : RS_DEBUG_LOG and RS_DEBUG_LOG_FMT to log in debug level * cleanups * cr (cherry picked from commit 3420e93) (cherry picked from commit 607a118)
meiravgri
added a commit
that referenced
this pull request
Mar 20, 2025
[MOD-9023] Replacing freeFlag with a reference counter (#5736) * add prints * fix * no depletion in getCursorCommand * add info to assert * free flag is now a ref counter to avoid potential race condition where one side is changing it twice. The refcount is increased when a new job is pushed to the queue, and decreased when the coordinator doesn't need any replies, or when all readers have done executing the job. introduce logging capabilities when ENABLE_ASSERT=1 : RS_DEBUG_LOG and RS_DEBUG_LOG_FMT to log in debug level * cleanups * cr (cherry picked from commit 3420e93) (cherry picked from commit 607a118)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
[2.10] [MOD-9023] Replacing freeFlag with a reference counter (#5784) [MOD-9023] Replacing freeFlag with a reference counter (#5736) * add prints * fix * no depletion in getCursorCommand * add info to assert * free flag is now a ref counter to avoid potential race condition where one side is changing it twice. The refcount is increased when a new job is pushed to the queue, and decreased when the coordinator doesn't need any replies, or when all readers have done executing the job. introduce logging capabilities when ENABLE_ASSERT=1 : RS_DEBUG_LOG and RS_DEBUG_LOG_FMT to log in debug level * cleanups * cr (cherry picked from commit 3420e93) (cherry picked from commit 607a118)
meiravgri
added a commit
that referenced
this pull request
Apr 26, 2025
[2.10] [MOD-9023] Replacing freeFlag with a reference counter (#5784) [MOD-9023] Replacing freeFlag with a reference counter (#5736) * add prints * fix * no depletion in getCursorCommand * add info to assert * free flag is now a ref counter to avoid potential race condition where one side is changing it twice. The refcount is increased when a new job is pushed to the queue, and decreased when the coordinator doesn't need any replies, or when all readers have done executing the job. introduce logging capabilities when ENABLE_ASSERT=1 : RS_DEBUG_LOG and RS_DEBUG_LOG_FMT to log in debug level * cleanups * cr (cherry picked from commit 3420e93) (cherry picked from commit 607a118) (cherry picked from commit d01e71d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #5736 to 2.10