[8.0] [MOD-9023] Replacing freeFlag with a reference counter #5762
Merged
[8.0] [MOD-9023] Replacing freeFlag with a reference counter #5762
Conversation
* add prints * fix * no depletion in getCursorCommand * add info to assert * free flag is now a ref counter to avoid potential race condition where one side is changing it twice. The refcount is increased when a new job is pushed to the queue, and decreased when the coordinator doesn't need any replies, or when all readers have done executing the job. introduce logging capabilities when ENABLE_ASSERT=1 : RS_DEBUG_LOG and RS_DEBUG_LOG_FMT to log in debug level * cleanups * cr (cherry picked from commit 3420e93)
meiravgri
changed the title
GuyAv46
approved these changes
Mar 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5762 +/- ##
==========================================
- Coverage 88.08% 88.06% -0.03%
==========================================
Files 200 200
Lines 36008 36018 +10
==========================================
- Hits 31719 31718 -1
- Misses 4289 4300 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #5736