[2.10] CP TIMEOUT related bugs & Query Debug Mechanism #5734
Merged
Conversation
decalre DistAggregateCommand in coord_module.h expose FT.DEBUG FT.AGGREGATE/SEARCH in coord debug commands merge coordinator code that was riginially (in master) in module, to coord/module
…ommandHandler skip wrokers if MT build is disabled
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #5734 +/- ##
==========================================
+ Coverage 87.66% 87.74% +0.07%
==========================================
Files 196 197 +1
Lines 34247 34509 +262
==========================================
+ Hits 30022 30279 +257
- Misses 4225 4230 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meiravgri
changed the title
raz-mon
reviewed
Mar 16, 2025
Collaborator
raz-mon
left a comment
raz-mon
left a comment
There was a problem hiding this comment.
LGTM 👍
One include maybe can be removed
raz-mon
approved these changes
Mar 17, 2025
GuyAv46
approved these changes
Mar 17, 2025
Collaborator
Author
|
/backport |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5734-to-2.8 origin/2.8
cd .worktree/backport-5734-to-2.8
git switch --create backport-5734-to-2.8
git cherry-pick -x c27cf7f3ec3b6c722a44643f0a2ced064e959458 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5734-to-2.6 origin/2.6
cd .worktree/backport-5734-to-2.6
git switch --create backport-5734-to-2.6
git cherry-pick -x c27cf7f3ec3b6c722a44643f0a2ced064e959458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #5554 to 2.10
fixing:
MOD-8483, MOD-8482, MOD-8515, MOD-8606, MOD-8794
debug query mechanism mod:
MOD-8605
Background
In master,
src/module.ccombines both coordinator and standalone logic, allowing to implementation of the debug mechanism for both modes in this file. However, in version 2.10, we still maintain separate files for each module:coord/module.csrc/module.cSimilarly,
debug_commands.cwas merged into a single file in master.Due to these structural differences, this cherry-pick had to be done manually to properly extract coordinator-related code and place it in the correct files.
Changes in Coordinator & Standalone Implementations
Dist<Aggregate/Search>Commandsrc/module.hcoord/src/coord_module.hsrc/module.ccoord/src/coord_module.cdebug_commands.cFT.DEBUG FT.SEARCH/AGGREGATE&&FT.DEBUG _FT.SEARCH/_FT.AGGREGATE,FT.DEBUG FT.SEARCH/AGGREGATEfor standalone mode or_FT.SEARCH/_FT.AGGREGATEwhen built withCOORD=1coord/src/debug_command.cFT.DEBUG FT.SEARCH/AGGREGATEparent->sctx->time.timeoutparent->sctx->timeoutGetNumShards_UnSafewas not cherry-picked, as it is not in use. Cluster mode is checked testing ifRS_COORDINATORmacro is defined.