[2.6] MOD-7896: Add weight factor to BM25 scoring calculation (#5670)#5712
Merged
Itzikvaknin merged 2 commits into2.6from Mar 3, 2025
Merged
[2.6] MOD-7896: Add weight factor to BM25 scoring calculation (#5670)#5712Itzikvaknin merged 2 commits into2.6from
Itzikvaknin merged 2 commits into2.6from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #5712 +/- ##
==========================================
+ Coverage 85.17% 85.19% +0.02%
==========================================
Files 185 185
Lines 31504 31504
==========================================
+ Hits 26833 26841 +8
+ Misses 4671 4663 -8 ☔ View full report in Codecov by Sentry. |
* Update BM25 scoring calculations to incorporate weight factor in explanations * Add weight to explainscore Expand testTFIDFScorerExplanation in test_scorers * Add testBM25STDScoreWithWeight and testBM25ScoreWithWeight to test_scorers * Fix testOptionalAndWildcardScoring * Fix testBM25STDScorerExplanation * Add docs to scorer_with_weight_test Fix BM25STD calculation * Remove unnecessary isCluster condition from test_scorers * Add hash seed to force docs distribution * Name change * Fix test_scorers:testBM25ScorerExplanation and test_scorers:testBM25STDScorerExplanation
Itzikvaknin
force-pushed
the
manual-backport-5670-to-2.6
branch
from
34a0068 to
c3867f3
Compare
raz-mon
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #5670 to 2.6
In the original PR to master, some tests used BM25STD, which isn't available in this version, so I modified them to use BM25.