Skip to content

[8.0] MOD-8862: Add DebugCTX mechanism and DebugIndexesScanner#5711

Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.0from
backport-5672-to-8.0
Mar 2, 2025
Merged

[8.0] MOD-8862: Add DebugCTX mechanism and DebugIndexesScanner#5711
redisearch-backport-pull-request[bot] merged 1 commit into8.0from
backport-5672-to-8.0

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

Description

Backport of #5672 to 8.0.

* Create dbg ctx and dbgIndScan

* Fix

* fixing mechanism and pytest

* Add pause before scan mechanism and pytest

* Revert "Add pause before scan mechanism and pytest"

This reverts commit b842ce9.

* Re-adding 'Add pause before scan mechanism and pytest'

* fix testDebugHelp

* fixing Guy's comment + skipping on cluster in pytest

* Move volatile pause to BG scanner,  move debug scanner flag to base IndexesScanner

* fix pytest

* thread safety

* Cover more code

* pause before scan coverage

* fix - can't create a flow to reach    'Debug mode enabled but scanner is not a debug scanner' error

* fixing Alon's comment

* wrong arity check and comment on not used function

* format

(cherry picked from commit a0536fe)
@codecov
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 92.96875% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (5be13f4) to head (92408f5).
Report is 2 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/debug_commands.c 89.02% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #5711      +/-   ##
==========================================
- Coverage   88.03%   88.01%   -0.02%     
==========================================
  Files         197      197              
  Lines       35544    35670     +126     
==========================================
+ Hits        31290    31395     +105     
- Misses       4254     4275      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Mar 2, 2025
Merged via the queue into 8.0 with commit 17a01a5 Mar 2, 2025
9 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-5672-to-8.0 branch March 2, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant