[8.0] MOD-7896: Add weight factor to BM25 scoring calculation#5702
Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.0from Feb 27, 2025
Merged
[8.0] MOD-7896: Add weight factor to BM25 scoring calculation#5702redisearch-backport-pull-request[bot] merged 1 commit into8.0from
redisearch-backport-pull-request[bot] merged 1 commit into8.0from
Conversation
* Update BM25 scoring calculations to incorporate weight factor in explanations * Add weight to explainscore Expand testTFIDFScorerExplanation in test_scorers * Add testBM25STDScoreWithWeight and testBM25ScoreWithWeight to test_scorers * Fix testOptionalAndWildcardScoring * Fix testBM25STDScorerExplanation * Add docs to scorer_with_weight_test Fix BM25STD calculation * Remove unnecessary isCluster condition from test_scorers * Add hash seed to force docs distribution * Name change * Fix test_scorers:testBM25ScorerExplanation and test_scorers:testBM25STDScorerExplanation (cherry picked from commit 65a4c9e)
Itzikvaknin
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5702 +/- ##
==========================================
+ Coverage 87.97% 88.00% +0.02%
==========================================
Files 197 197
Lines 35545 35544 -1
==========================================
+ Hits 31272 31279 +7
+ Misses 4273 4265 -8 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5670 to
8.0.