[2.8] MOD-7944: Support multi-byte char terms (#5391)#5647
Merged
Conversation
(cherry picked from commit 43701d8)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #5647 +/- ##
==========================================
+ Coverage 85.85% 85.90% +0.04%
==========================================
Files 200 200
Lines 34314 34399 +85
==========================================
+ Hits 29459 29549 +90
+ Misses 4855 4850 -5 ☔ View full report in Codecov by Sentry. |
raz-mon
previously approved these changes
Feb 17, 2025
oshadmi
reviewed
Feb 17, 2025
oshadmi
reviewed
Feb 18, 2025
oshadmi
reviewed
Feb 18, 2025
oshadmi
approved these changes
Feb 18, 2025
raz-mon
approved these changes
Feb 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #5391 to
2.8.(cherry picked from commit 43701d8)
Changes:
Since Version 2.8 limits the normalization buffer to 128 bytes,
#define MAX_NORMALIZE_SIZE 128, expected results intestLongTerms()were modified to respect that limitation.For tests with indexes with LANGUAGE different from ENGLISH, the LANGUAGE was added to FT.SEARCH commands because this version does not take the language from index specification
In
testMultibyteTag, for tests using DIALECT 4, the number of results was changed to ANY, because in this version a wrong count is returned.In test_cpp_llapi.cpp,
RediSearch_CreateTagLexRangeNode()receives only 5 arguments, in this versionconst char* fieldNameis not part of the function signature